Closed Bug 1370148 Opened 3 years ago Closed 3 years ago

system-info.getProperty("host") has been removed bug devtools still references it.

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: markh, Assigned: pbro)

References

Details

Attachments

(1 file)

Bug 1370148 - Stop using the missing system-info.getProperty(host);
59 bytes, text/x-review-board-request
jryans
: review+
Details 
Bug 1361601 removed system-info.getProperty("host"). However, devtools still appears to reference it at http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/devtools/shared/discovery/discovery.js#179.

Devtools may want to replace this with a call to |Cc["@mozilla.org/network/dns-service;1"].getService(Ci.nsIDNSService).myHostName|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment on attachment 8874388 [details]
Bug 1370148 - Stop using the missing system-info.getProperty(host);

https://reviewboard.mozilla.org/r/145750/#review149774

Thanks, looks good to me! :)
Attachment #8874388 - Flags: review?(jryans) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cc0b9a19f37
Stop using the missing system-info.getProperty(host); r=jryans
https://hg.mozilla.org/mozilla-central/rev/5cc0b9a19f37
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.