system-info.getProperty("host") has been removed bug devtools still references it.
RESOLVED
FIXED
in Firefox 55
Status
People
(Reporter: markh, Assigned: pbro)
Tracking
Firefox Tracking Flags
(firefox55 fixed)
Details
Attachments
(1 attachment)
Bug 1361601 removed system-info.getProperty("host"). However, devtools still appears to reference it at http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/devtools/shared/discovery/discovery.js#179. Devtools may want to replace this with a call to |Cc["@mozilla.org/network/dns-service;1"].getService(Ci.nsIDNSService).myHostName|
|
(Assignee) | |
Updated•2 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b314616e5c69bcd390bf26ab600f39fba3c91296
|
||
Comment 3•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874388 [details] Bug 1370148 - Stop using the missing system-info.getProperty(host); https://reviewboard.mozilla.org/r/145750/#review149774 Thanks, looks good to me! :)
Attachment #8874388 -
Flags: review?(jryans) → review+
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5cc0b9a19f37 Stop using the missing system-info.getProperty(host); r=jryans
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5cc0b9a19f37
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•8 months ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•