system-info.getProperty("host") has been removed bug devtools still references it.

RESOLVED FIXED in Firefox 55

Status

Product:
DevTools
Component:
General
Type:
defect
Status:
RESOLVED FIXED
Opened:
2 years ago
Updated:
Last year

People

(Reporter: markh, Assigned: pbro)

Tracking

Version:
Trunk
Target:
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Bug 1370148 - Stop using the missing system-info.getProperty(host);
59 bytes, text/x-review-board-request
jryans
: review+
Details
Reporter

Description

•
2 years ago 
Bug 1361601 removed system-info.getProperty("host"). However, devtools still appears to reference it at http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/devtools/shared/discovery/discovery.js#179.

Devtools may want to replace this with a call to |Cc["@mozilla.org/network/dns-service;1"].getService(Ci.nsIDNSService).myHostName|
 Assignee

Updated

•
2 years ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 3

•
2 years ago
mozreview-review 
Comment on attachment 8874388 [details]
Bug 1370148 - Stop using the missing system-info.getProperty(host);

https://reviewboard.mozilla.org/r/145750/#review149774

Thanks, looks good to me! :)
Attachment #8874388 - Flags: review?(jryans) → review+

Comment 4

•
2 years ago 
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cc0b9a19f37
Stop using the missing system-info.getProperty(host); r=jryans

Comment 5

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/5cc0b9a19f37
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

•
Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.