1370153 - stylo: Re-enable dom/xul/crashtests/461917-1.xhtml

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I disabled dom/xul/crashtests/461917-1.xhtml in bug 1290276 because it crashes on try, but I cannot reproduce it locally for now. 

Let's re-enabled this crashtest for stylo here.

Comment 1

[Cameron McCormack (:heycam)]

Just did a try run with this test re-enabled, it's still crashing, now with this assertion:

thread '<unnamed>' panicked at 'Resolving style on element without current styles', /home/worker/workspace/build/src/servo/ports/geckolib/glue.rs:2806

https://treeherder.mozilla.org/#/jobs?repo=try&revision=774847439410cdd32cee715b94b43d38f18014f3&selectedJob=116821222

Comment 2

[Bobby Holley (:bholley)]

As of [1] this is the last failing crashtest on stylo. We should fix it!

[1] https://hg.mozilla.org/integration/autoland/rev/91727c7a6f5bb08ea5297e6b82690ece6ca2cd38

Comment 3

[Cameron McCormack (:heycam)]

Oddly I still can't reproduce this locally, but I do get a few of these assertions:

[Child 1426] WARNING: stylo: requesting a Gecko declaration block?: file /z/moz/d/layout/style/ServoBindings.cpp, line 450

Comment 4

[Cameron McCormack (:heycam)]

Well, no luck in reproducing this locally, or on the build machine with logs enabled.  It would be nice if there were a way to dynamically turn on RUST_LOG=debug just for a certain test, but it looks like there's no way.  I do have a patch to fix the (unrelated) Gecko declaration block issue.

Comment 5

[Cameron McCormack (:heycam)]

I guess it's something funny with how the <tabs> or <wizards> XBL bindings work.  Since they can't be used in regular content documents, it's not high priority.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Doesn't seem to crash anymore: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ace451fcdd16e3024de294aeb6c6d6f824deb5dc

We can probably just enable it now.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1370153 - Re-enable dom/xul/crashtests/461917-1.xhtml.

Review commit: https://reviewboard.mozilla.org/r/193886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193886/

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8922715 [details]
Bug 1370153 - Re-enable dom/xul/crashtests/461917-1.xhtml.

https://reviewboard.mozilla.org/r/193886/#review198958

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6b2536fa997
Re-enable dom/xul/crashtests/461917-1.xhtml. r=xidorn

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6b2536fa997