1370172 - Stop using sdk/core/heritage in Console panel

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Console panel should stop using SDK, specifically sdk/core/heritage

http://searchfox.org/mozilla-central/source/devtools/client/webconsole/console-output.js#19

We might want to replace:

const { extend } = require("sdk/core/heritage");

with:

const extend = (prototype, properties) =>   Object.create(prototype, Object.getOwnPropertyDescriptor(properties));

See also:
bug 1368939 comment #2

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1370172 - Remove sdk/core/heritage from Console panel;

Review commit: https://reviewboard.mozilla.org/r/145768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145768/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8874397 [details]
Bug 1370172 - Remove sdk/core/heritage from Console panel;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145768/diff/1-2/

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8874397 [details]
Bug 1370172 - Remove sdk/core/heritage from Console panel;

https://reviewboard.mozilla.org/r/145768/#review152962

::: devtools/client/webconsole/console-output.js:33
(Diff revision 2)
>  const MAX_STRING_GRIP_LENGTH = 36;
>  const {ELLIPSIS} = require("devtools/shared/l10n");
>  
>  const validProtocols = /^(http|https|ftp|data|javascript|resource|chrome):/i;
>  
> +function extend(prototype, properties) {

I think you can simplify in:

const extend = (prototype, properties) =>
  Object.create(prototype, Object.getOwnPropertyDescriptors(properties));

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Jan Honza Odvarko [:Honza] from comment #0)

> const extend = (prototype, properties) =>   Object.create(prototype,
> Object.getOwnPropertyDescriptor(properties));
> 
> See also:
> bug 1368939 comment #2

My bad in this comment, I notice now the typo! (I forgot the "s"). :)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8874397 [details]
Bug 1370172 - Remove sdk/core/heritage from Console panel;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145768/diff/2-3/

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Matteo Ferretti [:zer0] [:matteo] from comment #3)
> I think you can simplify in:
> 
> const extend = (prototype, properties) =>
>   Object.create(prototype, Object.getOwnPropertyDescriptors(properties));
Done

Thanks for the review!

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65cf0b301f18
Remove sdk/core/heritage from Console panel; r=zer0

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/65cf0b301f18