Buildbot-configs tests are failing for KeyError: 'Windows 10 64-bit'

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mtabara, Assigned: mtabara)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=1319436#c7 for more details. I suspect it's infra related. Investigating ...
(Assignee)

Comment 1

7 months ago
2017-06-05 09:24:07,504 - Couldn't load test-output/bm81-tests_scheduler/master.cfg
Traceback (most recent call last):
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 113, in dump_master
    c = loadMaster(path)
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 26, in loadMaster
    execfile(path, g, g)
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm81-tests_scheduler/master.cfg", line 7, in <module>
    import config
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm81-tests_scheduler/config.py", line 2636, in <module>
    loadSkipConfig(BRANCHES, "desktop")
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm81-tests_scheduler/config_seta.py", line 165, in loadSkipConfig
    define_configs(b, platforms, BRANCHES)
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm81-tests_scheduler/config_seta.py", line 145, in define_configs
    platform = seta_platforms[p][0]
KeyError: 'Windows 10 64-bit'

This error makes me wonder if we missed adding the `Windows 10 64-bit` platform within https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config_seta.py#l15. However, I didn't find any recent changes on this seta-end so I could be totally wrong.

@kmoir: any idea if anything changed here recently?
Flags: needinfo?(kmoir)
(Assignee)

Comment 2

7 months ago
So it seems like https://hg.mozilla.org/build/buildbot-configs/file/tip/setup-master.py#l283 loads configuration from https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config_seta.py and fails along the way because there's no "Windows 10 64-bit".

In order to grab that platform, there's a call being made to alertmanager.allizom.org. Honestly I don't know anything about this service and/or who's managing it. In any case, I tested against all integration branches (for which we know SETA is enabled) for different dates in the past month and they all contain the "Windows 10 64-bit" so it must be taking it from somewhere else. 
 
http://alertmanager.allizom.org/data/setadetails/?date=2017-06-05&buildbot=1&branch=mozilla-central&inactive=1
http://alertmanager.allizom.org/data/setadetails/?date=2017-06-01&buildbot=1&branch=mozilla-central&inactive=1
http://alertmanager.allizom.org/data/setadetails/?date=2017-05-25&buildbot=1&branch=mozilla-central&inactive=1
http://alertmanager.allizom.org/data/setadetails/?date=2017-05-05&buildbot=1&branch=mozilla-central&inactive=1

all contain the "Windows 10 64-bit".

A possibility would be the "*-seta" configs from under https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config_seta.py#l83. All those files don't have any idea about Win10 yet but that doesn't explain how this worked in the past few weeks for example.
(Assignee)

Comment 3

7 months ago
I pushed a fix (adding the missing Win10 in the configs) under https://github.com/mozilla-releng/build-buildbot-configs/pull/11/files to check if the tests pass and they do. Not sure though what was the change in the automation in the past 4-5 days that triggered this. I'll ask Kim for review.
Comment hidden (mozreview-request)

Comment 5

7 months ago
We have some buildbot masters that have failed to complete their reconfigs lately. I wonder if this is the cause?

Comment 6

7 months ago
mozreview-review
Comment on attachment 8874413 [details]
Bug 1370182 - add missing Win10 information in config seta.

https://reviewboard.mozilla.org/r/145776/#review149708
Attachment #8874413 - Flags: review?(kmoir) → review+

Comment 7

7 months ago
I should have thought of this when we added the new win10 talos platform.  It takes a few days for seta to include data for new platforms, this is why the initial reconfigs when we deployed the platform didn't fail.  Thanks for fixing this Mihai!
Flags: needinfo?(kmoir)
(Assignee)

Comment 8

7 months ago
Comment on attachment 8874413 [details]
Bug 1370182 - add missing Win10 information in config seta.

Bug 1370182 - add missing Win10 information in config seta. r=kmoir
https://hg.mozilla.org/build/buildbot-configs/rev/f3b2449ff762
https://hg.mozilla.org/build/buildbot-configs/rev/6ce3b94b7236
Attachment #8874413 - Flags: checked-in+
(Assignee)

Comment 9

7 months ago
(In reply to Chris AtLee [:catlee] from comment #5)
> We have some buildbot masters that have failed to complete their reconfigs
> lately. I wonder if this is the cause?

Could be.

(In reply to Kim Moir [:kmoir] from comment #7)
> I should have thought of this when we added the new win10 talos platform. 
> It takes a few days for seta to include data for new platforms, this is why
> the initial reconfigs when we deployed the platform didn't fail.  Thanks for
> fixing this Mihai!

No worries! Thank for review, landed + reconfig completed.
Closing this now, proceeding back to mergeduty.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.