1370196 - Maybe add bind_bindFunction3 for Speedometer/react?

Status: RESOLVED INVALID

(Core :: JavaScript Engine, enhancement, P5)

Description

[André Bargull [:anba]]

The React version used in Speedometer calls Function.prototype.bind with three bound arguments, which means it currently uses the slower bind_bindFunctionN implementation. Maybe we should add bind_bindFunction3, so we can avoid some extra array allocations when merging the bound and call arguments.

Comment 1

[André Bargull [:anba]]

Numbers for a single run of React and React-Redux from InteractiveRunner.html (bound functions have a negligible use in the other frameworks).


Create bound functions:

React
  0-bound args: 759
  1-bound args: 100273
  2-bound args: 0
  3-bound args: 100
  4-bound args: 0
> 4-bound args: 0

React-Redux
  0-bound args: 711
  1-bound args: 265
  2-bound args: 0
  3-bound args: 0
  4-bound args: 0
> 4-bound args: 0


Calls to bound functions:

React
  0-bound args: 5969
  1-bound args: 1170
  2-bound args: 0
  3-bound args: 100
  4-bound args: 0
> 4-bound args: 0

React-Redux
  0-bound args: 44237
  1-bound args: 515
  2-bound args: 0
  3-bound args: 0
  4-bound args: 0
> 4-bound args: 0


So there are only 100 calls to create bound functions with three bound arguments.

Comment 2

[Mayank Bansal]

Is this fixed by bug 1483869 ?

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Mayank Bansal from comment #2)

Is this fixed by bug 1483869 ?

Yep. We can now also store up to 3 bound arguments inline, which nicely handles this case.