Closed Bug 1370221 Opened 5 years ago Closed 5 years ago

Crash in java.lang.ClassCastException: org.mozilla.gecko.sync.ExtendedJSONObject cannot be cast to java.io.Serializable at org.mozilla.gecko.sync.telemetry.TelemetryCollector.build(TelemetryCollector.java)

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Firefox 55
Unspecified
Android
defect

Tracking

(firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: calixte, Assigned: Grisha)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-dfb687eb-d526-4a6f-ac14-5835f0170605.
=============================================================

There are 52 crashes in nightly 55 with buildid 20170604100226. In alnalyzing the backtrace, the regression may have been introduced buy patch [1] to fix bug 1308337.

[1] https://hg.mozilla.org/mozilla-central/rev/02d589c299a4
Flags: needinfo?(gkruglov)
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Flags: needinfo?(gkruglov)
Priority: -- → P1
Crash Signature: [@ java.lang.ClassCastException: org.mozilla.gecko.sync.ExtendedJSONObject cannot be cast to java.io.Serializable at org.mozilla.gecko.sync.telemetry.TelemetryCollector.build(TelemetryCollector.java) ]
Depends on: 1370111
Comment on attachment 8874927 [details]
Bug 1370221 - Don't try to serialize ExtendedJSONObject

https://reviewboard.mozilla.org/r/146308/#review150308

I would prefer to serialize the JSON string, rather than an instance of `org.simple.json.JSONObject`, 'cuz long term I want to replace EJO's internal representation with `org.json.JSONObject`.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1204559.

This is time-critical however, so if you want to do this, I'm fine with it.
Attachment #8874927 - Flags: review?(nalexander) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2c80281949da -d c1ae34baf77a: rebasing 400437:2c80281949da "Bug 1370221 - Don't try to serialize ExtendedJSONObject r=nalexander" (tip)
merging mobile/android/services/src/main/java/org/mozilla/gecko/sync/telemetry/TelemetryCollector.java
warning: conflicts while merging mobile/android/services/src/main/java/org/mozilla/gecko/sync/telemetry/TelemetryCollector.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61f5e3d8517c
Don't try to serialize ExtendedJSONObject r=nalexander
https://hg.mozilla.org/mozilla-central/rev/61f5e3d8517c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.