1370240 - Enable the ESLint no-control-regex rule across mozilla-central

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

no-control-regex is already enabled for a few subdirectories, there's only one instance in the tree currently - that should be there. So I think we should enable it across the tree, and if we do need to break it, then it'll be obvious & intentional.

From:
http://eslint.org/docs/rules/no-control-regex
Control characters are special, invisible characters in the ASCII range 0-31. These characters are rarely used in JavaScript strings so a regular expression containing these characters is most likely a mistake.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1370240 - Enable the ESLint no-control-regex rule across mozilla-central.

Review commit: https://reviewboard.mozilla.org/r/145820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145820/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8874449 [details]
Bug 1370240 - Enable the ESLint no-control-regex rule across mozilla-central.

https://reviewboard.mozilla.org/r/145820/#review149780

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9eddc0d3345
Enable the ESLint no-control-regex rule across mozilla-central. r=mossop

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f9eddc0d3345