1370252 - Several jit-tests fail when run with incremental GC zeal

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

When I run the jit-tests with one of the incremental GC zeal modes I get a bunch of spurious failures because various tests try to start a GC when there is one running already due to zeal, e.g.:

~/clone/dev/js/src$ JS_GC_ZEAL=10 ./jit-test/jit_test.py optdebug-dist-build/shell gc
[  1|  0|  0|  0]   0% >                                               |   0.3s
/home/jon/clone/dev/js/src/jit-test/tests/basic/external-strings-cgc.js:2:1 Error: Incremental GC already in progress
Stack:
  @/home/jon/clone/dev/js/src/jit-test/tests/basic/external-strings-cgc.js:2:1
Exit code: 3
FAIL - basic/external-strings-cgc.js
[110|  1|  0|  0]  42% ==================>                            |   3.3s
/home/jon/clone/dev/js/src/jit-test/tests/gc/bug-1271110.js:35:1 Error: Incremental GC already in progress
Stack:
  @/home/jon/clone/dev/js/src/jit-test/tests/gc/bug-1271110.js:35:1
Exit code: 3
FAIL - gc/bug-1271110.js
[123|  2|  0|  0]  47% =====================>                         |   4.1s
/home/jon/clone/dev/js/src/jit-test/tests/gc/bug-1301496.js:4:1 Error: Incremental GC already in progress
Stack:
  @/home/jon/clone/dev/js/src/jit-test/tests/gc/bug-1301496.js:4:1
Exit code: 3
FAIL - gc/bug-1301496.js
...

We should fix this so we can test incremental GC without having to sift through a bunch of expected failures.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1370252-incremental-test

This patch makes disabling GC zeal finish any ongoing GC, and adds |gczeal(0)| to the start of all affected tests.

Running jit-tests with mode 10 (incremental zeal) now shows no failures.  Mode 17 has a bunch of timeouts but no failures.

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8874462 [details] [diff] [review]
bug1370252-incremental-test

Review of attachment 8874462 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, bleh.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cab8d95ff4a9
Fix spurious jit-tests failures with incremental zeal mode r=sfink

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cab8d95ff4a9