1370263 - Crash in mozilla::extensions::URLInfo::Scheme

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-78102839-3c9c-4267-8374-2516d0170605.
=============================================================

There is 1 crash in nightly 55 with buildid 20170605100313. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1322235.

[1] https://hg.mozilla.org/mozilla-central/rev?node=94a3fb9eb7e4c933ae318ff9b0a5bc9a3ac28e75

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1370263: Null check document URI before matching content scripts.

Review commit: https://reviewboard.mozilla.org/r/145870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145870/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8874500 [details]
Bug 1370263: Null check document URI before matching content scripts.

https://reviewboard.mozilla.org/r/145870/#review149804

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8874500 [details]
Bug 1370263: Null check document URI before matching content scripts.

https://reviewboard.mozilla.org/r/145870/#review149808

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f904e3d130ab951280c19ab2f32384fe30374bce
Bug 1370263: Null check document URI before matching content scripts. r=mixedpuppy

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f904e3d130ab

Comment 6

[[:philipp]]

the crash signature is still present in today's build 20170606030207 containing the patch:
https://crash-stats.mozilla.com/signature/build_id=>%3D20170606030207&signature=mozilla%3A%3Aextensions%3A%3AURLInfo%3A%3AScheme#reports

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1370263: Don't try to match content scripts for non-codebase principals.

Review commit: https://reviewboard.mozilla.org/r/146350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146350/

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8875001 [details]
Bug 1370263: Don't try to match content scripts for non-codebase principals.

https://reviewboard.mozilla.org/r/146350/#review150862

Kris is thinking more about DocInfo::Principal, clearing review for now

Comment 9

[YF (Yang)]

STR:
Nightly 55.0a1 (2017-06-10) + https://addons.mozilla.org/firefox/addon/copy-link-text-webextension/ 1.4.7.
Open Scratchpad.

Comment 10

[[:philipp]]

[Tracking Requested - why for this release]:
the two signatures account for ~10% of browser crashes in yesterday's nightly build (20170611030208).
it would be great if we got a fix in time for building beta 1.

Comment 11

[Gerry Chang [:gchang]]

Per comment #10, mark 55 blocking. It would be great if we can take this fix in 55.0b1.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Kris, Andy, this bug is deemed a blocker to gtb (go to build) 55.0b1 as it's a top crasher. Do you agree with that assessment? At the moment my plan is to block beta1 build until we have a fix for this. Will appreciate a prompt fix, if we know what that fix might be, we'd like to land it in the next hour or two so b1 schedule is not impacted. Thanks!

Comment 13

[Kris Maglione [:kmag]]

Attachment: Bug 1370263: Don't try to match content scripts for non-codebase principals.

Review commit: https://reviewboard.mozilla.org/r/148218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148218/

Comment 14

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8876889 [details]
Bug 1370263: Don't try to match content scripts for non-codebase principals.

https://reviewboard.mozilla.org/r/148218/#review152598

Comment 15

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dca7816cb61a698b60a376a0047390c0fce5cc2
Bug 1370263: Don't try to match content scripts for non-codebase principals. r=mixedpuppy

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Kris, Ryan, please land the patches on m-b asap. I'd like to include them in 55.0b1. In casethis causes a fallout based on tonight's Nightly, we can do a build2 after backing out this patch.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6190cf16cf23

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6dca7816cb61