137027 - Body Sanitized/AsPlain: This msg doesn't display

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Ben Bucksch (:BenB)]

(1) The following m/r msg (sent with current Mozilla) displays with a blank body
in the new HTML display modes Simple HTML and As Plaintext.
(2) Worse, when you switch to Original HTML and back while that msg is being
displayed, the load never finishes.

From the debugging output, my parse_line and parse_begin never gets called in
the first case. In the second case, parse_eof gets called once, then it stalls
after that exits, i.e. somewhere in code outside of the new classes.

J-F reports in bug 30888 that m/r works for him, apart from the fact that images
aren't being displayed.
Strange.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Problematic msg

Comment 2

[Ben Bucksch (:BenB)]

No idea, what's going on.

Comment 3

[Ben Bucksch (:BenB)]

Similarily, the msg in
<http://bugzilla.mozilla.org/attachment.cgi?id=74098&action=view> displays
blank, because parse_line is never being called. There, however, I see no
infinitive loads.

Comment 4

[[e-mail]]

I have seen something like this on various occasions: the message is shown
as completely blank when "View->Message body" is set to "as plain text" or
either "as plain text" or "simple html". 

This is a serious issue, because one would assume that the message really does
not contain any text when in fact, it does. 

Here is a cut/paste from "view message source" of a message that is empty 
for both "plain text" and "simple html" mode:
---start
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<FONT face=3DArial size=3D2>Liebe(r) UserIn, 
<br><br>Ihr Suchagent "Profil1" hat folgende Inserate=
 gefunden:<br><br>

  <a=
 href=3D"http://derStandard=2Eat/Stellenmarkt/?displayAd=3D14943">Diplo=
mschwestern/Pfleger &amp; -helferInnen</a><br>

<br><br>Ein Service von <a=
 href=3D"http://derStandard=2Eat/Karriere">derStandard=2Eat/Karriere</a=
><br><hr><br>Hinweise zur Verwendung:<br><br>Um diesen=
 Suchagenten zu aendern, zu loeschen oder abzubestellen, melden=
 Sie sich bitte auf der Seite <a=
 href=3D"http://derStandard=2Eat/Stellenmarkt">http://derStandard=2Eat/=
Stellenmarkt</a>  mit Ihrem derStandard=2Eat-Account an=2E Sie sehen=
 dann eine Liste Ihrer Suchagenten, mit Optionen zum Aendern,=
 Ausfuehren und Loeschen=2E<br><br>Wenn Sie diesen=
 Benachrichtigungsdienst abbestellen wollen, und ihn nicht selbst=
 eingerichtet haben sollten, dann wenden Sie sich bitte unter=
 Angabe Ihrer e-Mail Adresse und des Namens des Suchagenten an <a=
 href=3D"mailto:Inserate@derStandard=2Eat?subject=3DJob-Agenten fuer=
 johann=2Epetrak@chello=2Eat=
 abbestellen">Inserate@derStandard=2Eat</a>=2E<br></font>
---stop

Comment 5

[[e-mail]]

Attachment: A folder with two messages that show no text in plain text mode

Attached a email folder file with two messages.
The first message is shown completely blank for both "simple HTML" and 
"plain text", the second message is completely blank for "plain text" mode
only.

Comment 6

[Ben Bucksch (:BenB)]

johann, bug 126887 is filed for "text/html" without charset msgs.

Comment 7

[[e-mail]]

Ben, I dont understand - is this a bug that the message that is 
shown perfectly well as "original HTML" is completely blank for "simple HTML"
and "plain text" or not?

Comment 8

[Ben Bucksch (:BenB)]

sure it's a bug.

Comment 9

[FZiegler]

The test messages in bug 138125, comments 3, 4, 5, don't display in `Plain Text'
mode either.

Comment 10

[[e-mail]]

(2002073022/linux)
Not sure if this belongs here, but it is quite nasty: I just got an email
that shows only part of the content in Original HTML mode (it was sent by
yahoo and only the "original message" part in html is shown.
The actual message text is NOT shown and only appears in the other two modes.
It is a sensitive message so I cannot post it here, but will try to
anonymize it.
Since obviously significant parts of email messages can be dropped in
all three modes, this should be critical and dataloss, I would suggest.

Comment 11

[FZiegler]

Attachment: multipart/alternative, doesn't display in plain text mode

Ere's fix to bug 138125 also fixed this one for me -- all attachments here and
in comment 9 now display OK, both in Simple HTML and Plain Text mode. 

OTOH, I came across the attached multipart/alternative message, which displays
OK in Simple HTML but nothing in Plain Text mode. (Maybe only because no mime
type is set for that part -- and therefore not a bug? Still, I would think that
the sender intended it to be readable.)

Comment 12

[FZiegler]

Comment on attachment 107426 [details]
multipart/alternative, doesn't display in plain text mode

Yes, the problem here is the lack of a Mime descriptor for the first
alternative part. If I add:

Content-type: text/plain; charset="US-ASCII"

after "--this-is-a-separator-for-mime-parts", then it displays fine. So I guess
the question is, should this be fixed or ascribed to "evangelism"?

Comment 13

[[e-mail]]

This should by all means be fixed or at least show an error message: 
IMO, the ability
to read whatever wrongly encoded text a user received should have top
priority. It would be very dangerous to silently display nothing, which could
cause the recipient an awful lot of trouble indeed. Not all potential users
of MozillaMail  (or NS7 mail) are informed enough to investigate, do 
a view source etc. This is especially dangerous if it happens that only 
*part* of a message is not shown.

Comment 14

[Ben Bucksch (:BenB)]

> all attachments here and
> in comment 9 now display OK, both in Simple HTML and Plain Text mode.

-> ere, fixed

> OTOH, I came across the attached multipart/alternative message, which displays
> OK in Simple HTML but nothing in Plain Text mode. (Maybe only because no mime
> type is set for that part

This is probably unrelated. Yes, I think that message is totally broken, but I
agree that we shouldn't just display nothing. However, I am relatively sure that
this is unrelated not only to this bug, but not even in my code. Probably,
libmime can't handle m/a (and other m/ types? - please check) parts without
content type. We might have never his this bug, because we always chose the HTML
part (which needs a content-type anyways in order to work).

Comment 15

[Ben Bucksch (:BenB)]

fixed

Comment 16

[FZiegler]

Excuse me Ben, but there is a problem here that all who commented thus far
(Johann, you, and me) seem to agree cannot be summarily dismissed. So, I don't
mind if you close this bug again, but then at least open another to deal with
the problem!

(Only difference, so far as I can see, would be "m/a" in place of "m/r" in the
description. Bug summaries are about *symptoms*, aren't they?)

Comment 17

[Ben Bucksch (:BenB)]

hysterion, thanks for finding the bug, but it's not this bug. This bug is
another one. Please file a new one for the issue you found - that's your
responsibility as a reporter, not mine. reclosing as fixed.

Comment 18

[Ben Bucksch (:BenB)]

> Bug summaries are about *symptoms*, aren't they?

From a developer perspective, bugs are about *causes*. 2 bugs with the same
symptom should get 2 bugs in bugzilla.

Comment 19

[FZiegler]

Filed as bug 182035. Courteline, anyone?

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

Aha!  I was just about to comment that the 'View as Simple HTML' didn't work for
Ben's original http://bugzilla.mozilla.org/attachment.cgi?id=78826&action=view
message.  See bug 182021, which Harish just landed, so it should be fixed in
tomorrow's builds!

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

http://bugzilla.mozilla.org/attachment.cgi?id=78826&action=view now works using
View | Message Body As | Simple HTML (as well as the other options, Original
HTML | Plain Text).

Builds:

Mac OS X 10.2.3 - 2003-01-06-11
Windows 2000 - 2003-01-06-08
RedHat 8.0 - 2003-01-06-10

Verified FIXED