1370308 - SkiaGL canvas crashes with SharedSurface_SurfaceTexture

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We crash when copying from the texture to the SharedSurface because this path relies on GLContext::Screen() existing, but it does not.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1370308 - Don't crash when using SkiaGL with SurfaceTexture on Android

Review commit: https://reviewboard.mozilla.org/r/145882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145882/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8874514 [details]
Bug 1370308 - Don't crash when using SkiaGL with SurfaceTexture on Android

https://reviewboard.mozilla.org/r/145882/#review151046

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/069703dbf83d
Don't crash when using SkiaGL with SurfaceTexture on Android r=jgilbert

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/069703dbf83d