1370442 - Permaorange browser_keybindings_01.js | Test timed out when Gecko 55 merges to beta on 2017-06-12

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Phil Ringnalda (:philor)]

[Tracking Requested - why for this release]:

Something that landed in the last week is going to cause permaorange https://treeherder.mozilla.org/logviewer.html#?job_id=104743767&repo=try on opt and debug, every platform, beta and devedition, when we merge to beta next week.

Comment 1

[Phil Ringnalda (:philor)]

Sigh.

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1

Comment 2

[Julien Cristau [:jcristau]]

needs to be addressed before 55.0b1, marking as blocker

Comment 3

[Brian Grinstead [:bgrins]]

I'm guessing this has to do with the netmonitor key change in Bug 1368734 based on where the test is failing

Comment 4

[Brian Grinstead [:bgrins]]

Just testing a backout of https://hg.mozilla.org/try/rev/2d566ca89b454ce2789ce93e3aa7f481bd168b06.

Applied queue for the beta simulation, which should still fail: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5874fc805fcc7881107bba0b191c22d4f9bd9d34
Same queue, plus the backout: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1ef56080a98b33d571c4c1864711700d771ab29

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> Just testing a backout of
> https://hg.mozilla.org/try/rev/2d566ca89b454ce2789ce93e3aa7f481bd168b06.

Wrong URL, I meant: https://hg.mozilla.org/mozilla-central/rev/5be871146313

I'm not sure why that change would only affect beta builds, unless if there is some keybinding conflict with ctrl+shift+e/cmd+opt+e.  Another potential cause would be a change to the debugger if it stole focus away from the toolbox

Comment 6

[Brian Grinstead [:bgrins]]

Just reproduced locally by setting the devtools.debugger.new-debugger-frontend pref to false: https://dxr.mozilla.org/mozilla-central/source/devtools/client/preferences/debugger.js#4-8

Comment 7

[Brian Grinstead [:bgrins]]

I believe this is an interaction between the keybinding change in Bug 1368734 and the fact that we only have the old debugger frontend enabled in beta.  The old frontend swallows the new netmonitor shortcut

As I understand it, the current plan is to enable the new debugger frontend in 56, so we only need to fix this for 55.  Two main options for this that don't involve changing the old debugger ui:

1) Reorder the test in 55 so that netmonitor is tested before the debugger, acknowledging that the key shortcut won't work when the debugger is opened
2) Revert to the old shortcut in 55

Brought this up in a devtools meeting, and the team is generally leaning towards option 1 so we don't need to bump the shortcut string two more times and it won't interact with photon in m-c.  I'll attach a patch for beta that does so

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: Bug 1370442 - Update keybindings test to always use the new debugger frontend;

This is a workaround for one release of the old debugger frontend which swallows
the netmonitor shortcut.

Review commit: https://reviewboard.mozilla.org/r/146274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146274/

Comment 9

[Patrick Brosset <:pbro>]

Comment on attachment 8874896 [details]
Bug 1370442 - Update keybindings test to always use the new debugger frontend;

https://reviewboard.mozilla.org/r/146274/#review150584

::: devtools/client/framework/test/browser_keybindings_01.js:14
(Diff revision 1)
> +Services.prefs.setBoolPref("devtools.debugger.new-debugger-frontend", true);
> +registerCleanupFunction(function* () {
> +  Services.prefs.clearUserPref("devtools.debugger.new-debugger-frontend");
> +});

Shouldn't we use something like this instead:

```
yield pushPref("devtools.debugger.new-debugger-frontend", true);
```

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/364a31932fe3
Update keybindings test to always use the new debugger frontend;r=pbro

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/364a31932fe3