1370474 - [Form Autofill] Manage Profiles and Edit Profile dialogs should close on ESC key

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement)

Description

[Scott Wu [:scottwu]]

When the manage profiles dialog (manageProfiles.xhtml) and edit profile dialog (editProfile.xhtml) are opened as subdialogs, they should close when ESC key is pressed.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1370474 - (Part 1) Make editProfile more like manageProfiles for consistency.

Review commit: https://reviewboard.mozilla.org/r/151676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151676/

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1370474 - (Part 2) editProfile and manageProfiles dialogs close on ESC key press.

Review commit: https://reviewboard.mozilla.org/r/151678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151678/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8880325 [details]
Bug 1370474 - (Part 1) Make editProfile more like manageProfiles for consistency.

https://reviewboard.mozilla.org/r/151676/#review156674

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8880326 [details]
Bug 1370474 - (Part 2) editProfile and manageProfiles dialogs close on ESC key press.

https://reviewboard.mozilla.org/r/151678/#review156676

Comment 5

[Scott Wu [:scottwu]]

Thanks Luke. The tests looks fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0bd6cb33130&selectedJob=109183343

Checking it in.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac80dbdf4c2
(Part 1) Make editProfile more like manageProfiles for consistency. r=lchang
https://hg.mozilla.org/integration/autoland/rev/6fb55211d93e
(Part 2) editProfile and manageProfiles dialogs close on ESC key press. r=lchang

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ac80dbdf4c2
https://hg.mozilla.org/mozilla-central/rev/6fb55211d93e