Closed Bug 1370474 Opened 5 years ago Closed 5 years ago

[Form Autofill] Manage Profiles and Edit Profile dialogs should close on ESC key

Categories

(Toolkit :: Form Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

Details

Attachments

(2 files)

When the manage profiles dialog (manageProfiles.xhtml) and edit profile dialog (editProfile.xhtml) are opened as subdialogs, they should close when ESC key is pressed.
No longer blocks: fx-form-autofill-prefs
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
Comment on attachment 8880325 [details]
Bug 1370474 - (Part 1) Make editProfile more like manageProfiles for consistency.

https://reviewboard.mozilla.org/r/151676/#review156674
Attachment #8880325 - Flags: review?(lchang) → review+
Comment on attachment 8880326 [details]
Bug 1370474 - (Part 2) editProfile and manageProfiles dialogs close on ESC key press.

https://reviewboard.mozilla.org/r/151678/#review156676
Attachment #8880326 - Flags: review?(lchang) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ac80dbdf4c2
(Part 1) Make editProfile more like manageProfiles for consistency. r=lchang
https://hg.mozilla.org/integration/autoland/rev/6fb55211d93e
(Part 2) editProfile and manageProfiles dialogs close on ESC key press. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3ac80dbdf4c2
https://hg.mozilla.org/mozilla-central/rev/6fb55211d93e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.