1370509 - [Static Analysis][Useless call] In function nsSliderFrame::BuildDisplayListForChildren

Status: RESOLVED INVALID

(Core :: XUL, defect, P5)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that the call:

>>aBuilder->GetCurrentReferenceFrame();

is useless since the returned value is not used.

Comment 1

[Martin Boros]

Attachment: Removed the offending line

Hi, I'm still very new to this, I removed the pointless function call and attached the diff file. Let me know if anything else is needed, thanks.

Comment 2

[meghasharma4910]

Has this bug been resolved or is it still open? If yes, I would like to take it up.

Comment 3

[Andi [:andi]]

(In reply to Martin Boros from comment #1)
> Created attachment 8880993 [details] [diff] [review]
> Removed the offending line
> 
> Hi, I'm still very new to this, I removed the pointless function call and
> attached the diff file. Let me know if anything else is needed, thanks.

Do you still want to continue with this bug? Your patch only needs a reviewer and also a tile having the bug id and a very brief description on what it does, and the reviewer. More on this topic can be read here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction


(In reply to meghasharma4910 from comment #2)
> Has this bug been resolved or is it still open? If yes, I would like to take
> it up.
Let's wait a little bit and see if the owner of the patch still wants to continue the work on it.

Comment 4

[Andi [:andi]]

(In reply to meghasharma4910 from comment #2)
> Has this bug been resolved or is it still open? If yes, I would like to take
> it up.

Hello if you are still interested in this bug you can take it and continue the work on it as Martin didn't reply to the message.

Comment 5

[arieguy]

Hello. 
New here so apologies if I'm missing something. Offending line doesn't seem to exist any more.

Comment 6

[Andi [:andi]]

(In reply to arieguy from comment #5)
> Hello. 
> New here so apologies if I'm missing something. Offending line doesn't seem
> to exist any more.

You are right! Thank you!

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336