1370514 - Links in editing mode need to be fixed

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: General, enhancement)

Description

[Kadir Topal [:atopal]]

In editing mode we show a question mark symbol next to the "Tags", "Revision Comment", and "Attachments" headlines. Those links need to be updated to link to the correct section of the page they are linking to.

Tags:
from https://developer.mozilla.org/en-US/docs/Project:MDN/Contributing/Editor_guide/Editing#The_tags_box
To https://developer.mozilla.org/en-US/docs/MDN/Contribute/Editor/Basics#The_tags_box

Revision Comment:
From https://developer.mozilla.org/en-US/docs/Project:MDN/Contributing/Editor_guide/Editing#The_revision_comment_box
To https://developer.mozilla.org/en-US/docs/MDN/Contribute/Editor/Basics#The_revision_comment_box

Attachments:
From https://developer.mozilla.org/en-US/docs/Project:MDN/Contributing/Editor_guide/Editing#The_attachments_box
To https://developer.mozilla.org/en-US/docs/MDN/Contribute/Editor/Basics#The_attachments_box

Comment 1

[John Whitlock [:jwhitlock]]

I agree, good first bug.  The links can be found using Github search, like:

https://github.com/mozilla/kuma/search?utf8=✓&q=The_tags_box&type=

Comment 2

[jozefkarabelly]

Hello can I start working on this bug?

Comment 3

[John Whitlock [:jwhitlock]]

Yes! I'll mark you as assigned. Let me know how it is going.

Comment 4

[jozefkarabelly]

Are there any tests that need to be run and should I add someone's username to the pull request for a review?

Comment 5

[John Whitlock [:jwhitlock]]

:sebo Thanks for needinfo'ing me and setting to assigned.

jozefkarabelly, this change doesn't need tests, we'll just use manual testing. You can ping me (jwhitlock on GitHub) for the review.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7966cb57dea336a68eabf52ea0619018696a5451
bug 1370514 - fixed links in editing mode

https://github.com/mozilla/kuma/commit/97599fecf56939a53a9c1dabd3d9c7b602cabf60
bug 1370514: Allow fragments in wiki_url

https://github.com/mozilla/kuma/commit/90e035aa83b27747b84f2baa413ac22c1ec388d9
Merge pull request #4286 from karabellyj/new-issue-1370514

bug 1370514 - fixed links in editing mode

Comment 7

[John Whitlock [:jwhitlock]]

This is now in production. Thanks jozefkarabelly!

Comment 8

[Sebastian Zartner [:sebo]]

I can confirm that it works now. Thank you, Jozef!

Sebastian