1370550 - onwheel is not present on HTMLElement

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Domenic Denicola]

See tests in https://github.com/w3c/web-platform-tests/pull/6165. Unlike all other (implemented) GlobalEventHandlers, onwheel is not present on HTMLElement. It still works fine though, so it's implemented somehow.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

It is in Element

Comment 2

[Andrew Overholt [:overholt]]

Is this bug INVALID, then (the tests on that PR seem to pass in Firefox?)?

Comment 3

[Domenic Denicola]

No, the tests do not pass:

Fail	onwheel: must be on the appropriate locations for GlobalEventHandlers	assert_true: HTMLElement has an own property named "onwheel" expected true got false

@http://localhost:8000/html/webappapis/scripting/events/event-handler-all-global-events.html:27:9
Test.prototype.step@http://localhost:8000/resources/testharness.js:1408:20
test@http://localhost:8000/resources/testharness.js:498:9
@http://localhost:8000/html/webappapis/scripting/events/event-handler-all-global-events.html:25:5

Comment 4

[Andrew Overholt [:overholt]]

Sorry, didn't see that. We'll figure something out here.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So right now we have "onwheel" on Document/Window/Element.

Spec has it on GlobalEventHandlers, which is implemented by HTMLElement/SVGElement/Window/XULElement/Document.

So moving it would effectively remove it from non-HTML/SVG element as far as the web is concerned.

Looks like our placement of it dates back to before it was actually in a spec at all, so we should just move it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Move the onwheel attribute to GlobalEventHandlers, to follow the spec

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea84b4c23270
Move the onwheel attribute to GlobalEventHandlers, to follow the spec.  r=smaug

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea84b4c23270

Comment 9

[Chris Mills [:cmills]]

I've made sure that HTMLElement is said to implement from GlobalEventHandlers:

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onwheel

I've also added a note to the Fx56 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/56#DOM