1370598 - Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air.

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P3)

Description

[Thomas Daede [:TD-Linux]]

pacmd list-sink-inputs shows:

    index: 252
	driver: <protocol-native.c>
	flags: START_CORKED 
	state: RUNNING
	sink: 1 <alsa_output.pci-0000_00_1b.0.analog-stereo>
	volume: front-left: 65536 / 100% / 0.00 dB,   front-right: 65536 / 100% / 0.00 dB
	        balance 0.00
	muted: no
	current latency: 224.47 ms
	requested latency: 6.26 ms
	sample spec: float32le 2ch 44100Hz
	channel map: front-left,front-right
	             Stereo
	resample method: copy
	module: 13
	client: 57 <Nightly>
	properties:
		media.name = "AudioCallbackDriver"
		application.name = "Nightly"
		native-protocol.peer = "UNIX socket client"
		native-protocol.version = "32"
		application.process.id = "24891"
		application.process.user = "thomas"
		application.process.host = "homura"
		application.process.binary = "firefox"
		application.language = "en_US.utf8"
		window.x11.display = ":1"
		application.process.machine_id = "8e4cbfea404512ae70096c6202c9a3bf"
		application.process.session_id = "3"
		application.icon_name = "firefox"
		module-stream-restore.id = "sink-input-by-application-name:Nightly"

For some reason the current latency is much higher than the requested latency. One reason may be that Firefox is pushing frames into Pulseaudio long before it needs to. 224ms isn't horrible, but it could be much better.

Comment 1

[Paul Adenot (:padenot)]

Was the load very high maybe ?

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1370598 - Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air.

Review commit: https://reviewboard.mozilla.org/r/213190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213190/

Comment 4

[Paul Adenot (:padenot)]

Comment on attachment 8942922 [details]
Bug 1370598 - Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213190/diff/1-2/

Comment 5

[Alex Chronopoulos [:achronop]]

Comment on attachment 8942922 [details]
Bug 1370598 - Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air.

https://reviewboard.mozilla.org/r/213190/#review218890

Looks good!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f745765d92c4
Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air. r=achronop

Comment 7

[Paul Adenot (:padenot)]

Oh no, this is the wrong bug...

Comment 8

[Paul Adenot (:padenot)]

Filed bug 1430827 for this.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f745765d92c4