1370601 - Make it possible for offerer and answerer to switch roles in jsep_session_unittest.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Dan Minor [:dminor]]

This is part of Bug 1329028 that can be rebased and landed independently. Making it possible for the offerer and answerer to switch roles will improve test coverage.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1370601 - Make it possible for offerer and answerer to switch roles in jsep_session_unittest.cpp;

Review commit: https://reviewboard.mozilla.org/r/147252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147252/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8875850 [details]
Bug 1370601 - Make it possible for offerer and answerer to switch roles in jsep_session_unittest.cpp;

https://reviewboard.mozilla.org/r/147252/#review151882

::: media/webrtc/signaling/gtest/jsep_session_unittest.cpp:5374
(Diff revision 1)
> +  std::string actpass = "\r\na=setup:actpass";
> +  size_t match = reoffer.find(actpass);
> +  ASSERT_NE(match, std::string::npos);
> +  reoffer.replace(match, actpass.length(), "\r\na=setup:active");
> +
> +  SetRemoteOffer(reoffer, NO_CHECKS);

Let's add a comment here that we're expecting SetRemoteOffer to fail.

::: media/webrtc/signaling/gtest/jsep_session_unittest.cpp:5403
(Diff revision 1)
> +  std::string actpass = "\r\na=setup:active";
> +  size_t match = reanswer.find(actpass);
> +  ASSERT_NE(match, std::string::npos);
> +  reanswer.replace(match, actpass.length(), "\r\na=setup:passive");
> +
> +  SetRemoteAnswer(reanswer, NO_CHECKS);

Same sort of thing here.

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8875850 [details]
Bug 1370601 - Make it possible for offerer and answerer to switch roles in jsep_session_unittest.cpp;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147252/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b51c4d61a69f
Make it possible for offerer and answerer to switch roles in jsep_session_unittest.cpp; r=bwc

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b51c4d61a69f