bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove XPCOMBinaryComponent and related mozbuild code

RESOLVED FIXED in Firefox 56

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: Chris Manchester (mostly offline July 16-20), Assigned: Chris Manchester (mostly offline July 16-20))

Tracking

unspecified
mozilla56

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

We have the template, the entry in python/mozbuild/mozpack/chrome/manifest.py, some frontend variables, various checks around 'IS_COMPONENT' in config/rules.mk, and and various moz.build tests.
Assignee: nobody → cmanchester
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153092

I'd rather not touch the packager code until at least the xpcom manifest parser support for binary-component is removed. Even then, I think it's still useful to be able to use e.g. unpack.py on older Firefox releases.

Please remove the files referenced in MOZ_COMPONENTS_VERSION_SCRIPTS_LDFLAGS.
Attachment #8877278 - Flags: review?(mh+mozilla)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153190
Attachment #8877278 - Flags: review?(mh+mozilla) → review+

Comment 5

a year ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51d1ab9b2e52
Remove build system code handling binary components. r=glandium
https://hg.mozilla.org/mozilla-central/rev/51d1ab9b2e52
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.