1370695 - Remove XPCOMBinaryComponent and related mozbuild code

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

We have the template, the entry in python/mozbuild/mozpack/chrome/manifest.py, some frontend variables, various checks around 'IS_COMPONENT' in config/rules.mk, and and various moz.build tests.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1370695 - Remove build system code handling binary components.

Review commit: https://reviewboard.mozilla.org/r/148608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148608/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153092

I'd rather not touch the packager code until at least the xpcom manifest parser support for binary-component is removed. Even then, I think it's still useful to be able to use e.g. unpack.py on older Firefox releases.

Please remove the files referenced in MOZ_COMPONENTS_VERSION_SCRIPTS_LDFLAGS.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148608/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153190

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d1ab9b2e52
Remove build system code handling binary components. r=glandium

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/51d1ab9b2e52