Closed Bug 1370695 Opened 3 years ago Closed 3 years ago

Remove XPCOMBinaryComponent and related mozbuild code

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

We have the template, the entry in python/mozbuild/mozpack/chrome/manifest.py, some frontend variables, various checks around 'IS_COMPONENT' in config/rules.mk, and and various moz.build tests.
Assignee: nobody → cmanchester
Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153092

I'd rather not touch the packager code until at least the xpcom manifest parser support for binary-component is removed. Even then, I think it's still useful to be able to use e.g. unpack.py on older Firefox releases.

Please remove the files referenced in MOZ_COMPONENTS_VERSION_SCRIPTS_LDFLAGS.
Attachment #8877278 - Flags: review?(mh+mozilla)
Comment on attachment 8877278 [details]
Bug 1370695 - Remove build system code handling binary components.

https://reviewboard.mozilla.org/r/148608/#review153190
Attachment #8877278 - Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51d1ab9b2e52
Remove build system code handling binary components. r=glandium
https://hg.mozilla.org/mozilla-central/rev/51d1ab9b2e52
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.