1370732 - Define Cc and Ci in sanitize.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1370732 - Define Cc and Ci in sanitize.js.

These are referred to, but never explicitly defined. Under some
circumstances with shared JSM globals, this will cause an error.

Review commit: https://reviewboard.mozilla.org/r/146760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146760/

Comment 2

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a2a0cb80ebdc23d843d564a69c789dbb0228f96

Comment 3

[:Gijs (he/him)]

Comment on attachment 8875350 [details]
Bug 1370732 - Define Cc and Ci in sanitize.js.

https://reviewboard.mozilla.org/r/146760/#review150860

::: browser/base/content/sanitize.js:31
(Diff revision 1)
> +var Cc = Components.classes;
> +var Ci = Components.interfaces;

Nit: you could use a destructuring assignment as we do elsewhere.

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to :Gijs from comment #3)
> Nit: you could use a destructuring assignment as we do elsewhere.

Sounds good. I'll do that.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8875350 [details]
Bug 1370732 - Define Cc and Ci in sanitize.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146760/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ae5d273a149
Define Cc and Ci in sanitize.js. r=Gijs

Comment 7

[Andrew McCreight [:mccr8]]

Oops, I did the destructuring assignment backwards...

Comment 8

[Andrew McCreight [:mccr8]]

I guess I have to file a new bug for this because of MozReview?

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ae5d273a149