1370736 - "Reconnect to Sync" label sticks around after confirming sign-in

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[:Grisha Kruglov]

I've changed my password, and got a "Reconnect to Sync" label in the new Photon browser menu. However, this label did not disappear after logging in and confirming my sign-in via email.

Label did disappear after clicking on it (which took me to Firefox Accounts setting pane which was in a "all good" state).

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I can't reproduce this now that bug 1369092 is fixed. Grisha, is it possible you were testing a build without that fix?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond [:markh] from comment #1)
> I can't reproduce this now that bug 1369092 is fixed. Grisha, is it possible
> you were testing a build without that fix?

hrm - I can reproduce strangeness here in some cases

Comment 3

[Mark Hammond [:markh] [:mhammond]]

The problem I can reproduce is:

* Sync fails, Weave.Status.login gets set to LOGIN_FAILED_LOGIN_REJECTED, menu shows "needs reauth"
* We re-sign in - UIState.jsm sees the observer notifications and tries to update its state.
* UIState.jsm calls _loginFailed(), which finds Weave.Status.login as still LOGIN_FAILED_LOGIN_REJECTED, so says we are still in a failed state.
* Eventually sync completes, but the observer notifications for completion doesn't attempt to update the user state. Note however that I don't think this is what we should fix - we shouldn't need to wait for the next sync for the state to update correctly.

I think the simplest (and reasonable) fix is for browserid_identity to reset the login state back to OK when it sees the login notification - patch forthcoming.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1370736 - reset the sync login status after an FxA login event.

Review commit: https://reviewboard.mozilla.org/r/146582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146582/

Comment 5

[Edouard Oger [:eoger]]

Comment on attachment 8875179 [details]
Bug 1370736 - reset the sync login status after an FxA login event.

https://reviewboard.mozilla.org/r/146582/#review150786

Sounds good

Comment 6

[Edouard Oger [:eoger]]

Let's try to land this before the merge (or uplift it if we're too late).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8df2372798c5
reset the sync login status after an FxA login event. r=eoger

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8df2372798c5