Closed Bug 1370736 Opened 5 years ago Closed 5 years ago

"Reconnect to Sync" label sticks around after confirming sign-in

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Grisha, Assigned: markh)

Details

Attachments

(1 file)

I've changed my password, and got a "Reconnect to Sync" label in the new Photon browser menu. However, this label did not disappear after logging in and confirming my sign-in via email.

Label did disappear after clicking on it (which took me to Firefox Accounts setting pane which was in a "all good" state).
I can't reproduce this now that bug 1369092 is fixed. Grisha, is it possible you were testing a build without that fix?
(In reply to Mark Hammond [:markh] from comment #1)
> I can't reproduce this now that bug 1369092 is fixed. Grisha, is it possible
> you were testing a build without that fix?

hrm - I can reproduce strangeness here in some cases
The problem I can reproduce is:

* Sync fails, Weave.Status.login gets set to LOGIN_FAILED_LOGIN_REJECTED, menu shows "needs reauth"
* We re-sign in - UIState.jsm sees the observer notifications and tries to update its state.
* UIState.jsm calls _loginFailed(), which finds Weave.Status.login as still LOGIN_FAILED_LOGIN_REJECTED, so says we are still in a failed state.
* Eventually sync completes, but the observer notifications for completion doesn't attempt to update the user state. Note however that I don't think this is what we should fix - we shouldn't need to wait for the next sync for the state to update correctly.

I think the simplest (and reasonable) fix is for browserid_identity to reset the login state back to OK when it sees the login notification - patch forthcoming.
Comment on attachment 8875179 [details]
Bug 1370736 - reset the sync login status after an FxA login event.

https://reviewboard.mozilla.org/r/146582/#review150786

Sounds good
Attachment #8875179 - Flags: review?(eoger) → review+
Let's try to land this before the merge (or uplift it if we're too late).
Assignee: nobody → markh
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/8df2372798c5
reset the sync login status after an FxA login event. r=eoger
https://hg.mozilla.org/mozilla-central/rev/8df2372798c5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.