1370746 - about:prefs#sync doesn't update when the account state changes.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

STR:
* Open about:prefs#sync, note the account state says it is OK.
* Open some other tab so about:accounts#prefs is not the current tab.
* On some other device change the FxA password.
* Wait for hamburger menu to change to "needs reauth".
* Click on the hamburger item to reauth.

The existing about:prefs tab is switched to, but its state hasn't changed to "please sign in".

Comment 1

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Attachment: Bug 1370746 - about:prefs#sync listens for more FxA account state notifications.

Review commit: https://reviewboard.mozilla.org/r/146594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146594/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8875189 [details]
Bug 1370746 - about:prefs#sync listens for more FxA account state notifications.

https://reviewboard.mozilla.org/r/146594/#review150790

Nice! This page should probably be refactored to use UIState.jsm, but it works well for now and it's not very important anyway.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a1e31e98aab
about:prefs#sync listens for more FxA account state notifications. r=eoger

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a1e31e98aab

Comment 5

[Fahima Zulfath]

Managed to reproduce the issue on an affected build (Firefox 55.0b4, Build ID: 20170622104007), using the steps to reproduce from Comment 0, on Windows 10x64. F X A is synced with current account in any number of tabs has be opened.
[Testday - 20170623]