1370781 - Permaorange browser_offlineQuotaNotification.js | about:preferences loaded - Got about:preferences#advanced, expected about:preferences#privacy when Gecko 55 merges to beta on 2017-06-12

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Phil Ringnalda (:philor)]

When we merge central to beta next week, we're going to have permaorange in browser_offlineQuotaNotification.js like https://treeherder.mozilla.org/logviewer.html#?job_id=105059989&repo=try

Should be able to repro locally by just changing /config/milestone.txt from 55.0a1 to 55.0, but if not locally or on try on top of https://hg.mozilla.org/try/rev/a3e416c66e714e2e63e2afb35529f6d698b60eb9 and https://hg.mozilla.org/try/rev/e45e86a84f88c54475eb733a116c51a49010d1df will reproduce.

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1

Comment 1

[Julien Cristau [:jcristau]]

This is a blocker for 55.0b1

Comment 2

[Mike Taylor [:miketaylr]]

jaws, is there someone who can take a look? (I know this bug is less than a day old...forgive the aggressive regression triaging here).

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Ricky, can you look in to this?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

FYI, this is currently marked as blocking Monday's merge of 55 to Beta.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Jared, after investigating for a while, I'm still unclear of why this mochitest failure occurs.

This problem can reproduce easily as mentioned on description, set milestone.txt from 55.0a1 to 55.0 can hit this failure.

However, all mochitests will freeze the browser with following message:

...

GECKO(75494) | 2017-06-09 12:04:57.278 plugin-container[75495:2099922] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port
 = 0xa703, name = 'com.apple.CFPasteboardClient'
GECKO(75494) | See /usr/include/servers/bootstrap_defs.h for the error codes.
GECKO(75494) | 1496981097283    Marionette      INFO    Listening on port 2828
GECKO(75494) | 1496981097397    Marionette      DEBUG   loaded listener.js
GECKO(75494) | 1496981097429    addons.xpi      WARN    Add-on [e-mail] is not compatible with application version.
GECKO(75494) | 1496981097432    addons.xpi      WARN    Add-on [e-mail] is not compatible with application version.
GECKO(75494) | 1496981097508    addons.update-checker   WARN    Request failed: http://127.0.0.1:8888/extensions-dummy/updateURL - 404: Not Found
GECKO(75494) | 1496981097610    addons.xpi      WARN    Add-on [e-mail] is not compatible with application version.
GECKO(75494) | 1496981097612    addons.xpi      WARN    Add-on [e-mail] is not compatible with application version.
GECKO(75494) | 1496981097619    addons.update-checker   WARN    Request failed: http://127.0.0.1:8888/extensions-dummy/updateURL - 404: Not Found

I can't see "http://127.0.0.1:8888/extensions-dummy/updateURL - 404: Not Found" warning as above after switching to 55.0a1.

On the other hand, 55.0 is running on old preferences page with browser.preferences.useOldOrganization = true but 55.0a1 is running on new UI which is opposite of it. I'm suspecting that this could be due to apply the correct prefs when running mochitest on 55.0 build. This might be the reason why bug 1370439 failed as well.

Do you have any idea?

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Ah, I believe Tim found out the root cause in bug 1370439 and it's very likely due to bug 1363850.

let's wait for the try report at https://bugzilla.mozilla.org/show_bug.cgi?id=1370439#c7.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1370781 - Run offlineQuotaNotification test on new preferences

Review commit: https://reviewboard.mozilla.org/r/147528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147528/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8876102 [details]
Bug 1370781 - Run offlineQuotaNotification test on new preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147528/diff/1-2/

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8876102 [details]
Bug 1370781 - Run offlineQuotaNotification test on new preferences

https://reviewboard.mozilla.org/r/147528/#review151870

So this test got updated to test against the new preferences, and when the preferences got reverted for 55, this test will start failing because it would need to be changed back.

Setting r+ on this means that we aren't testing what we ship for 55, but it does mean we'll continue to test what we're shipping in 56. Considering we aren't likely to make any large changes to 55 since it's entering beta next week, I'm OK with this.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/656e918f28c0
Run offlineQuotaNotification test on new preferences r=jaws

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/656e918f28c0