Closed
Bug 1370787
Opened 8 years ago
Closed 8 years ago
Add a test for bug 1367581
Categories
(Firefox :: Private Browsing, enhancement)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
|
4.92 KB,
patch
|
smaug
:
review+
valentin
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8903127 [details] [diff] [review]
Patch
Review of attachment 8903127 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Valentin
Since you reviewed my bug 1367581
could you also help to review this test?
Thanks
Attachment #8903127 -
Flags: review?(valentin.gosu)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8903127 [details] [diff] [review]
Patch
Review of attachment 8903127 [details] [diff] [review]:
-----------------------------------------------------------------
It looks OK to me, but I'd rather a docshell peer reviewed this.
Attachment #8903127 -
Flags: review?(valentin.gosu)
Attachment #8903127 -
Flags: review?(bugs)
Attachment #8903127 -
Flags: feedback+
|
||
Updated•8 years ago
|
Attachment #8903127 -
Flags: review?(bugs) → review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cabeb992038
add test for download file in PrivateBrowsing mode. r=smaug
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•