1370806 - Remove current selection before setting input.value

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Makoto Kato [:m_kato]]

nsIPlaintestEditor.setText still use BeginPlaceHolderTransaction and EndPlaceHolderTransaction.  But since input.value setter doesn't create undo transaction, it is unnecessary to save/restore selection via AutoPlaceHolderBatch.  Save/Restore selection is ~7% of input.value setter.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1370806 - Part 1. Use RAII class for StartBatchChanges and EndBatchChanges.

Although we use StartBatchChanges and EndBatchChanges in nsTextEditorState::SetValue, we have a path that EndBatchChanges isn't called.  So we should use RAII class to call EndBatchChanges correctly.

Review commit: https://reviewboard.mozilla.org/r/146956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146956/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1370806 - Part 2. Remove selection before calling nsIPlaintextEditor.setText.

nsIPlaintestEditor.setText still use BeginPlaceHolderTransaction and EndPlaceHolderTransaction.  But since input.value setter doesn't create undo transaction, it is unnecessary to save/restore selection via AutoPlaceHolderBatch.  So before calling setText, we should reset selection to reduce saving and restoring selection.

Save/Restore selection is ~7% of input.value setter.

Review commit: https://reviewboard.mozilla.org/r/146958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146958/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8875530 [details]
Bug 1370806 - Part 1. Use RAII class for StartBatchChanges and EndBatchChanges.

https://reviewboard.mozilla.org/r/146956/#review151158

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8875531 [details]
Bug 1370806 - Part 2. Remove selection before calling nsIPlaintextEditor.setText.

https://reviewboard.mozilla.org/r/146958/#review151160

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29687a739c34
Part 1. Use RAII class for StartBatchChanges and EndBatchChanges. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/efb90e3387f0
Part 2. Remove selection before calling nsIPlaintextEditor.setText. r=masayuki

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/29687a739c34
https://hg.mozilla.org/mozilla-central/rev/efb90e3387f0