Remove current selection before setting input.value

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks 1 bug)

55 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

nsIPlaintestEditor.setText still use BeginPlaceHolderTransaction and EndPlaceHolderTransaction.  But since input.value setter doesn't create undo transaction, it is unnecessary to save/restore selection via AutoPlaceHolderBatch.  Save/Restore selection is ~7% of input.value setter.
Blocks: 1346723
Comment on attachment 8875531 [details]
Bug 1370806 - Part 2. Remove selection before calling nsIPlaintextEditor.setText.

https://reviewboard.mozilla.org/r/146958/#review151160
Attachment #8875531 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/29687a739c34
Part 1. Use RAII class for StartBatchChanges and EndBatchChanges. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/efb90e3387f0
Part 2. Remove selection before calling nsIPlaintextEditor.setText. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/29687a739c34
https://hg.mozilla.org/mozilla-central/rev/efb90e3387f0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1376856
You need to log in before you can comment on or make changes to this bug.