Closed
Bug 1370823
Opened 8 years ago
Closed 8 years ago
Don't evict the nursery in NukeCrossCompartmentWrappers and RecomputeWrappers
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
5.00 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
These calls actually show up quite a lot when browsing, so it would be nice to not evict the nursery all the time.
* NukeCrossCompartmentWrappers doesn't need to evict because it should be fine to nuke a nursery-allocated wrapper AFAICS.
* RecomputeWrappers can check if we actually have nursery-allocated wrappers and then evict only if that's the case (usually it's not).
Attachment #8875208 -
Flags: review?(jcoppeard)
|
Assignee | |
Comment 1•8 years ago
|
||
Linux64 debug and opt is green on Try.
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8875208 [details] [diff] [review]
Patch
Review of attachment 8875208 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8875208 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/514cd61f92a0
Don't evict the nursery in NukeCrossCompartmentWrappers and RecomputeWrappers. r=jonco
|
||
Comment 4•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•