Don't evict the nursery in NukeCrossCompartmentWrappers and RecomputeWrappers

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Posted patch PatchSplinter Review
These calls actually show up quite a lot when browsing, so it would be nice to not evict the nursery all the time.

* NukeCrossCompartmentWrappers doesn't need to evict because it should be fine to nuke a nursery-allocated wrapper AFAICS.

* RecomputeWrappers can check if we actually have nursery-allocated wrappers and then evict only if that's the case (usually it's not).
Attachment #8875208 - Flags: review?(jcoppeard)
Linux64 debug and opt is green on Try.
Comment on attachment 8875208 [details] [diff] [review]
Patch

Review of attachment 8875208 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8875208 - Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/514cd61f92a0
Don't evict the nursery in NukeCrossCompartmentWrappers and RecomputeWrappers. r=jonco
https://hg.mozilla.org/mozilla-central/rev/514cd61f92a0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1371240
You need to log in before you can comment on or make changes to this bug.