1370826 - Add parameters names in Function grip

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

It would be quite nice if the grip contains the parameters of a function so we can display them in the console.

This should handle simple cases as a first step : 
```
function foo(a, b) {}
```
would have a `parameters` property containing `["a", "b"]`.

In a follow-up, it would be nice if we could handle more elaborated cases like:
```
// default values
function foo(a = 2, b = c){}
// destructuring
function foo({ x: _x = 20, y }, [a, b]){}
// rest
function foo(a, b, ...rest){}
```

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1370826 - Render parameter names in function rep. r=Honza.

For some reason the parameterNames was expected as
a prop, but it's available on the function grip
itself.
The rep is fixed, and tests are modified to reflect
this change.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fe8330c1912
Render parameter names in function rep. r=Honza.

Comment 3

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1370826, bug 1601559) for Devtools failures in devtools/client/debugger/test/mochitest/browser_dbg-sourcemapped-scopes.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280490230&repo=autoland&lineNumber=11204

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=37142aec03d7b990c2ae8ab0a05c19c97180587d

Backout:
https://hg.mozilla.org/integration/autoland/rev/315e5a8a441219612b762ad959efcc8bb853115d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ea980df5548
Render parameter names in function rep. r=Honza.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3ea980df5548