1370858 - <input type=date> datepicker doesn't fire change event

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jeroen Pulles]

Attachment: datepicker.html

The new datepicker widget for <input type=date> doesn't fire change events. 

I expected to get change events when I click on a date in the picker panel,

and I expect to get change events when typing a date in the text field and then blurring the input. 

The value property of the input does show the edited value when polled (see attached example).

I'm running Firefox Nightly: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 1

[Jessica Jong [:jessica] (inactive)]

Works on <input type="time">, let me see what's going on.

Comment 2

[Jessica Jong [:jessica] (inactive)]

NS_FORM_INPUT_DATE missing in HTMLInputElement::MayFireChangeOnBlur() [1], fixing it now.


[1] http://searchfox.org/mozilla-central/rev/d840ebd5858a61dbc1622487c1fab74ecf235e03/dom/html/HTMLInputElement.h#1612-1617

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Hi Olli, details are in the patch comment.
I've added tests only for changing value from the keyboard, since we do not have a way for testing picker yet.

Comment 4

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7b28fe42f9109b912eb4c53c55f53fef3d7be82&group_state=expanded

There some failures but seems not related to this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20882c387b4e
Fire change/input events after selecting a date/time from picker. r=smaug

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/20882c387b4e

Comment 7

[u615946]

on removing the value in an input of type date by clicking the (x) will not yet fire the change-event

v59.0.2 &
v60.0b11 Developer

Comment 8

[u615946]

I´ll disable my account, because i don´t want to publish my mail for other users/bots, very disappointing. hope the comment remains.