137091 - Page Setup Box changes size when switching between Portrait/Landscape

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Gustav]

In Page Setup, If you switch between Portrait and Landscape,
the box changes size although there seems to be no need for that.

Comment 1

[André Dahlqvist]

Sorry, I guess this belongs in Print Preview after all...

Comment 2

[Vadim Berezniker]

i'm seeing this as well with linux trunk 2002041218

Comment 3

[rods (gone)]

-->

Comment 4

[Eric Vaandering (no email)]

Also on RC3

Comment 5

[Paul Gregg]

Confirmed  Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.1a+) Gecko/20020703 SP6a
Ugly  ->  UI polish

Comment 6

[Stefan Borggraefe]

Attachment: Proposed Fix

Fixes the bug. Also adds the missing id to the <dialog> (this prevented persist
from working).

Comment 7

[Stefan Borggraefe]

Comment on attachment 157888 [details] [diff] [review]
Proposed Fix

Neil, do you think there is a cleaner way?

Comment 8

[[e-mail]]

Comment on attachment 157888 [details] [diff] [review]
Proposed Fix

I know there's a cleaner way, because I was able to test it in DOM inspector
;-) I'd like to see the Margins groupbox retain its size in landscape view.
Also please change <tabpanel orient="vertical"> to <vbox> while you're making
fixes.

Comment 9

[Giacomo Magnini]

Is this going to fix also the misalignment of portait/landscape text beside images?

Comment 10

[Doug Halamay]

Any news on this fix?  Bug 240817 is a dupe.

Comment 11

[Stefan Borggraefe]

(In reply to comment #10)
> Any news on this fix?  Bug 240817 is a dupe.

I haven't figured out the cleaner way to fix this bug yet (see comment 8). :-(
Bug 240817 is the Firefox-version of this bug.

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 310014 has been marked as a duplicate of this bug. ***

Comment 13

[Giacomo Magnini]

Can we close this bug as INVALID?
On both FF 1.5.0.x and SM trunk, the dialog doesn't change size anymore. Ok, portrait and horizontal strings are not centered vertically, but that would be a different bug...

Comment 14

[Percy Cabello]

I'm still seeing the same behavior in Windows XP SP2, default theme, with Firefox 2 RC2-candidate.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/2006100319 Firefox/2.0

Comment 15

[Giacomo Magnini]

(In reply to comment #14)
> I'm still seeing the same behavior in Windows XP SP2, default theme, with
> Firefox 2 RC2-candidate.

Hmmm... I was referring to Linux versions before, and the bug is Linux specific: change OS?

Comment 16

[Gabriele Best [:Gabri]]

Any news?

Comment 17

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This seems dumb that we haven't fixed it yet, but it's too late (again, argh) to block on this.  If a patch shows up we'd consider it, though.

Comment 18

[Martijn Wargers (dead)]

Attachment: patch

This seems to fix it for me.
Also changes tabpanel to vbox as suggested by Neil.

Comment 19

[Gabriele Best [:Gabri]]

Thats good!

Comment 20

[Damon Sicore (:damons)]

Comment on attachment 307956 [details] [diff] [review]
patch

a1.9+=damons

Comment 21

[Reed Loden [:reed]]

Checking in toolkit/components/printing/content/printPageSetup.xul;
/cvsroot/mozilla/toolkit/components/printing/content/printPageSetup.xul,v  <--  printPageSetup.xul
new revision: 1.13; previous revision: 1.12
done
Checking in xpfe/global/resources/content/printPageSetup.xul;
/cvsroot/mozilla/xpfe/global/resources/content/printPageSetup.xul,v  <--  printPageSetup.xul
new revision: 1.18; previous revision: 1.17
done