1371095 - ImageTracker does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Daniel Holbert [:dholbert]]

Could you post a sentence or two about which particular calls you're concerned with here?

We just ran across this bug in [qf] nomination bug triage, and we have no idea how to prioritize it. :)  Eliminating hashtable lookups is big, though, clearly, so this is probably [qf:p1] assuming that there's something to be done here.

(Alternately: maybe you've got a patch nearly ready, which will make this clearer...)

Comment 2

[Mats Palmgren (inactive)]

WIP:  https://hg.mozilla.org/try/rev/eb08ecc61a6bd75575df3d0f4d9ee46a586c3d5c

Comment 3

[Mats Palmgren (inactive)]

Attachment: Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove

Fairly straightforward: replace Get+Put with LookupForAdd,
and Get+Remove with LookupRemoveIf.

Comment 4

[Daniel Holbert [:dholbert]]

Triaging as [qf:p1], as straightforward removal of redundant hashtable lookups (known in general to be involved in QF perf issues).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cb9923c169
Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove.  r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46cb9923c169