ImageTracker does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [qf:p1])

Attachments

(1 attachment)

Comment hidden (empty)
Could you post a sentence or two about which particular calls you're concerned with here?

We just ran across this bug in [qf] nomination bug triage, and we have no idea how to prioritize it. :)  Eliminating hashtable lookups is big, though, clearly, so this is probably [qf:p1] assuming that there's something to be done here.

(Alternately: maybe you've got a patch nearly ready, which will make this clearer...)
Flags: needinfo?(mats)
(Assignee)

Comment 2

3 months ago
WIP:  https://hg.mozilla.org/try/rev/eb08ecc61a6bd75575df3d0f4d9ee46a586c3d5c
Flags: needinfo?(mats)
(Assignee)

Comment 3

2 months ago
Created attachment 8876106 [details] [diff] [review]
Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove

Fairly straightforward: replace Get+Put with LookupForAdd,
and Get+Remove with LookupRemoveIf.
Attachment #8876106 - Flags: review?(nfroyd)

Updated

2 months ago
Attachment #8876106 - Flags: review?(nfroyd) → review+
Triaging as [qf:p1], as straightforward removal of redundant hashtable lookups (known in general to be involved in QF perf issues).
Whiteboard: [qf] → [qf:p1]

Comment 5

2 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cb9923c169
Avoid doing unnecessary hashtable lookups in ImageTracker::Add/Remove.  r=froydnj

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/46cb9923c169
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.