1371179 - |mach run --debug| fails with "AttributeError: 'RunProgram' object has no attribute 'debuggerInfo'" with MozillaBuild 3.0

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

I don't know what happens, but I guess it may be related to my recent switch to MSVC 2017.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

So I think the issue is that mozdebug.get_default_debugger_name() fails to locate the debugger because no debugger is in PATH when open from start-shell.bat directly.

Comment 2

[Sotaro Ikeda [:sotaro]]

I also faced the same problem since I updated mozilla-build. Then I re-used old mozilla-build, I did not see the problem.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like this is broken by the most recent mozilla-build. A change in path handling means that devenv.exe is no longer on the path, so when get_default_debugger_name searches for a debugger it can't find one. There's also a lack of graceful handling around this error path in the python code.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm not familiar with if the moz.configure[1] code can interact with the mozdebug[2] code, if at all. My thought is mozdebug can't reach any of the moz.configure code, which means it can't easily grab the Visual Studio directory from the congfig, then use that to search for the debugger. :ted.mielczarek, are you familiar with this? Do you have any thoughts as to the best way to address this? Is there somewhere that moz.configure and mozdebug could share the code to hunt for Visual Studio?

(correction to my previous comment, it's get_debugger_info which will search and fail to find the debugger)

[1]: https://searchfox.org/mozilla-central/source/build/moz.configure/toolchain.configure#429
[2]: https://searchfox.org/mozilla-central/source/testing/mozbase/mozdebug/mozdebug/mozdebug.py

Comment 5

[(not currently active) Ted Mielczarek]

Oh, that's a bummer. We could put a check for devenv.exe in moz.configure (probably in windows.configure) and either make mach commands pass that down, or have mozdebug conditionally import the buildconfig module and pull it out, something like:
try:
  import buildconfig
  devenv = buildconfig.substs.get('DEVENV')
except ImportError:
  devenv = None