1371180 - Create compiler switches to remove features which Orfox must remove or disable

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P3)

Description

[Ethan Tseng [:ethan]]

1. Removes the Contacts and System Alert Window permissions
https://github.com/guardianproject/tor-browser/commit/e1ed6cd82a127f3b14d05935e6b570c107b39f36 

2. Removes the NFC permission and feature
https://github.com/guardianproject/tor-browser/commit/93527c9c913f8b178bdea6b847c775afb76fa509 

3. Removes shumway inclusion
https://github.com/guardianproject/tor-browser/commit/a2a15f3cb2daaa3b6f613765a46b90f48ad3ddfd 

4. Remove healthreporter manifest
https://github.com/guardianproject/tor-browser/commit/e1947abeef945cb166e8c6ef1c3f5b5e693610c0 

5. Search Widget? (Not sure the reasoning behind this)
https://github.com/guardianproject/tor-browser/commit/f415a732a8e50c2c34f43d905c36af5027bf7bb0 

6. AppDir storage stuff
https://github.com/guardianproject/tor-browser/commit/c995c897f9535439fd64230b3620c30eec0aac7c

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Ethan Tseng [:ethan] from comment #0)
> 1. Removes the Contacts and System Alert Window permissions
> https://github.com/guardianproject/tor-browser/commit/
> e1ed6cd82a127f3b14d05935e6b570c107b39f36 

Contacts have been removed from the product.  Tab Queues (which uses the SYSTEM_ALERT_WINDOW permission) is no longer gated, however, and I doubt we'd add a flag to disable it.  Do we even still want to remove this permission?

> 2. Removes the NFC permission and feature
> https://github.com/guardianproject/tor-browser/commit/
> 93527c9c913f8b178bdea6b847c775afb76fa509 

It is not possible to set MOZ_ANDROID_BEAM (which controls NFC) off, but it's easy to make that possible.  See https://searchfox.org/mozilla-central/source/mobile/android/moz.configure#74 and replace the project_flag (which can't be set) to something that can be set.

> 3. Removes shumway inclusion
> https://github.com/guardianproject/tor-browser/commit/
> a2a15f3cb2daaa3b6f613765a46b90f48ad3ddfd 

Shumway is long since dead.

> 4. Remove healthreporter manifest
> https://github.com/guardianproject/tor-browser/commit/
> e1947abeef945cb166e8c6ef1c3f5b5e693610c0 

This is no longer relevant as of Bug 1183320.

> 5. Search Widget? (Not sure the reasoning behind this)
> https://github.com/guardianproject/tor-browser/commit/
> f415a732a8e50c2c34f43d905c36af5027bf7bb0

This is also gone, as of https://bugzilla.mozilla.org/show_bug.cgi?id=1221344.

> 6. AppDir storage stuff
> https://github.com/guardianproject/tor-browser/commit/
> c995c897f9535439fd64230b3620c30eec0aac7c

I don't know anything about this.  Is it still an issue?