137121 - createaccount.cgi emits "Content-type: text/html" twice

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect, P2)

Description

[Andreas Krüger]

One of the first things createaccount.cgi *always* does is, it clears the 
cookies.  In that code, there already is a "Content-type". 

Createaccount.cgi then calls CheckEmailSyntax(), which prints "Content-type" a 
second time.

That second time is no longer interpreted as a HTTP-Header, so it becomes 
visible on the browser screen.

Comment 1

[Andreas Krüger]

Excuse the noise - CheckEmailSyntax() prints the header a second time _if_ the 
email does not fit the syntax required.

Comment 2

[Vlad Dascalu]

This got fixed on the trunk, it's only present in the 2.16 branch.

Wanted for 2.16.5 according to justdave.

Comment 3

[Vlad Dascalu]

Attachment: Version 1

2.16 sucks, we don't have Bugzilla->cgi, and a lot of other things. :-)

If we try to make $vars->{'header_done'} = 1, then the whole HTML header
disappears. :-)

Not sure that this approch is 100% the right thing to do, but it solves the
problem, and there's only one instance of it, as far as I can see.

Comment 4

[Vlad Dascalu]

Comment on attachment 142189 [details] [diff] [review]
Version 1

Tested, it works.

Comment 5

[Jouni Heikniemi]

Comment on attachment 142189 [details] [diff] [review]
Version 1

Ewww, but r=jouni since it works. I can't remember how the headers get printed
out in 2.16, but basically this looks pretty non-intrusive.

Comment 6

[Vlad Dascalu]

Checking in createaccount.cgi;
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v  <--  createaccount.cgi
new revision: 1.21.2.5; previous revision: 1.21.2.4
done