[Photon] Overflow panel shouldn't try to open in customize mode when dragging items over it

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
3 months ago
20 days ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

53 Branch
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
We've made the overflow button visible in customize mode, but now its panel shows up when dragging items on top of it (despite the button being marked disabled, and the panel empty because its contents are in customize mode).

The drag handlers should either be removed in customize mode and then readded, or (probably simpler) check whether the button is disabled before doing anything.

Happily, this doesn't happen with the photon pref disabled.
Flags: qe-verify+

Updated

3 months ago
Priority: -- → P3
QA Contact: gwimberly
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Iteration: --- → 56.1 - Jun 26
Priority: P3 → P1
Whiteboard: [reserve-photon-structure] → [photon-structure]
(Assignee)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8880391 [details]
Bug 1371236 - don't try to open the overflow panel when in customize mode,

https://reviewboard.mozilla.org/r/151760/#review156734

::: browser/components/customizableui/CustomizableUI.jsm:4183
(Diff revision 1)
> -      let overflowableToolbarInstance = this;
> -      this._panel.addEventListener("popupshown", function(aEvent) {
> -        this.addEventListener("dragover", overflowableToolbarInstance);
> +      this._panel.addEventListener("popupshown", (aEvent) => {
> +        this._panel.addEventListener("dragover", this);
> +        this._panel.addEventListener("dragend", this);
> -        this.addEventListener("dragend", overflowableToolbarInstance);

Not strictly necessary, but I noticed this and thought I might as well tidy it up a bit.

Comment 3

2 months ago
mozreview-review
Comment on attachment 8880391 [details]
Bug 1371236 - don't try to open the overflow panel when in customize mode,

https://reviewboard.mozilla.org/r/151760/#review157308

Cool, nice and simple. Thanks for the drive-by cleanup.

::: browser/components/customizableui/CustomizableUI.jsm:4183
(Diff revision 1)
>        // case the edit controls are in it.
>        this._panel.addEventListener("popupshowing", () => doc.defaultView.updateEditUIVisibility(), {once: true});
>        this._panel.openPopup(anchor || this._chevron);
>        this._chevron.open = true;
>  
> -      let overflowableToolbarInstance = this;
> +      this._panel.addEventListener("popupshown", (aEvent) => {

nit, drop the parens on aEvent
Attachment #8880391 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 5

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5af23c6f9303
don't try to open the overflow panel when in customize mode, r=jaws

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5af23c6f9303
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 7

2 months ago
I have reproduced this bug with nightly 55.0a1 (2017-06-08)  on ubuntu 16.04(64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1 .

Build ID 	20170627100221
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170628]

Comment 8

2 months ago
I have reproduce this bug with Nightly 55.0a1 (2017-06-08)) on Windows 8.1 (64 Bit).

This bug's fix is verified on Latest Nightly 56.0a1.

Build ID : 20170627030209
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170628]

Comment 9

2 months ago
As per Comment 7 and Comment 8, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified

Updated

2 months ago
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.