Closed Bug 1371249 Opened 4 years ago Closed 4 years ago

use stricter prototype for SSL_SignatureMaxCount

Categories

(NSS :: Libraries, enhancement)

Product:
NSS
Component:
Libraries
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ueno, Unassigned)

Details

Attachments

(1 file)

ssl-strict-proto.patch
1021 bytes, patch
KaiE
: review+
Details | Diff | Splinter Review 
Currently SSL_SignatureMaxCount() is declared as:

  SSL_IMPORT unsigned int SSL_SignatureMaxCount();

in ssl.h.  This causes a warning if -Wstrict-prototype is used:

  /usr/include/nss3/ssl.h:392:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]

This can be avoided by providing explicit argument list as:

  SSL_IMPORT unsigned int SSL_SignatureMaxCount(void);

This was originally reported as:
https://bugzilla.redhat.com/show_bug.cgi?id=1387086
Attachment #8875683 - Flags: review?(kaie)
Comment on attachment 8875683 [details] [diff] [review]
ssl-strict-proto.patch

r=kaie
Attachment #8875683 - Flags: review?(kaie) → review+
https://hg.mozilla.org/projects/nss/rev/d9998f7a7291
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.32
You need to log in before you can comment on or make changes to this bug.