1371263 - Selecting particular caches on about:cache via checkboxes results in cryptic error

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Georg Koppen]

Let's assume you are in permanent private browsing mode and want to inspect the entries in your cache via the about:cache page. After opening that page you want to see all the private entries. You tick the respective checkbox and hit the "Update"-button.

You get greeted with "Unrecognized storage name 'null'" and nothing happens. What should have happened is an update of the list of cache entries which you then may select for closer inspection.

Comment 1

[Georg Koppen]

Attachment: 0001-Bug-1371263-Improve-about-cache-page-when-selecting-.patch

Attached is a patch that we are shipping in Tor Browser to fix this issue. It is against mozilla-central (not ESR 52).

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8875707 [details] [diff] [review]
0001-Bug-1371263-Improve-about-cache-page-when-selecting-.patch

Review of attachment 8875707 [details] [diff] [review]:
-----------------------------------------------------------------

could you just append || ""; at [1] and be done?

f- only for the bad formatting and how the patch was submitted (you really ship this??).  just FYI, please submit patches with 8 line context.  Then, the assignment line should look like: storage = "";  But if you agree on the above suggestion this is moot anyway.


[1] https://dxr.mozilla.org/mozilla-central/rev/e61060be36424240058f8bef4c5597f401bc8b7e/toolkit/components/aboutcache/content/aboutCache.js#9

Comment 3

[Georg Koppen]

Attachment: bug_1371263.patch

Sorry for the bad formatting. I like your idea and have implemented it in the attached patch.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8876096 [details] [diff] [review]
bug_1371263.patch

Review of attachment 8876096 [details] [diff] [review]:
-----------------------------------------------------------------

If you verified the problem is fixed with it, let's get it in!  thanks.

Comment 5

[Georg Koppen]

(In reply to Honza Bambas (:mayhemer) from comment #4)
> Comment on attachment 8876096 [details] [diff] [review]
> bug_1371263.patch
> 
> Review of attachment 8876096 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If you verified the problem is fixed with it, let's get it in!  thanks.

Yes, I did that on my Linux box.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae536496bc6d
Improve about:cache page. r=mayhemer

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae536496bc6d