If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Facebook's volume bar glitches when hovering over the volume button

RESOLVED FIXED in Firefox 55

Status

()

Core
Layout: Web Painting
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: emilghitta, Assigned: cjku)

Tracking

({regression})

55 Branch
mozilla56
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ fixed, firefox56 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
[Affected versions]:
Firefox 55.0a1 (Build Id:20170607030206)

[Unaffected versions]:
Firefox 54.0 (Build Id:20170605134926)
Firefox 53.0.3 (Build Id:20170518000419)
Firefox 52.2.0esr (Build Id:20170607123825)

[Affected platforms]:
 Mac OS X 10.12.1
 Ubuntu 16.04  64bit.
 Windows 10 64 bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Access the https://www.facebook.com/ webpage.
3. Log In.
4. Go to any video.
5. Mute the video.
6. Hover over the volume button.

[Expected result]:
No UI issues are encountered.

[Actual result]:
A glitch can be observed on the volume bar.

[Regression range]:
This seems to be a regression:
Last good revision: baf05f61bc14fdf45511bc1165ce76daa08c5c0f
First bad revision: cf4e37d17683e0cbe134debc1d3685fb3f84e3d1

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=baf05f61bc14fdf45511bc1165ce76daa08c5c0f&tochange=cf4e37d17683e0cbe134debc1d3685fb3f84e3d1

[Additional notes]:
For further details regarding this issue, access the following link to observe the screen cast: https://drive.google.com/open?id=0B94iuIVMr-TETWY3eXptLUhFRVU

No sure if chosen the correct component, fell free to change it if necessary.
Emil, is it possible for you to use mozregression to limit the regression range down to a specific patch? That would help tracking this down.
Has Regression Range: --- → yes
Flags: needinfo?(emil.ghitta)
Priority: -- → P3
Whiteboard: [gfx-noted]
The most likely candidate in that regression range is bug 1205475.
Blocks: 1205475
Flags: needinfo?(cku)
(In reply to Markus Stange [:mstange] from comment #2)
> The most likely candidate in that regression range is bug 1205475.

Yes, I've locally backed out patches in bug 1205475 and the build looks good.
Assignee: nobody → cku
Status: NEW → ASSIGNED
Flags: needinfo?(emil.ghitta)
Priority: P3 → P1
Component: Graphics → Layout: Web Painting
(Assignee)

Comment 4

3 months ago
I will handle it.
Flags: needinfo?(cku)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8877402 - Flags: review?(matt.woodrow)

Comment 7

3 months ago
mozreview-review
Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

https://reviewboard.mozilla.org/r/148798/#review153290
Attachment #8877402 - Flags: review?(matt.woodrow) → review+

Comment 8

3 months ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2574d7124fa
In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child. r=mattwoodrow
[Tracking Requested - why for this release]: As FF55 migrated to beta now, we need to uplift the patch to beta when the fix is verified in nightly56.
status-firefox56: --- → affected
tracking-firefox55: --- → ?
https://hg.mozilla.org/mozilla-central/rev/c2574d7124fa
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
tracking as new regression in 55
tracking-firefox55: ? → +
Please request Beta approval on this when you get a chance.
Flags: needinfo?(cku)
(Assignee)

Comment 13

3 months ago
Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1205475
[User impact if declined]: Facebook's volume bar glitches when hovering over the volume button
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]: NA
[Is the change risky?]: no
[Why is the change risky/not risky?]: small patch
[String changes made/needed]:N/A
Flags: needinfo?(cku)
Attachment #8877402 - Flags: approval-mozilla-beta?
Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

fix a regression in beta55.

No automated test and no manual verification doesn't sound too great though...
Attachment #8877402 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 15

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/7d8707908aa0
status-firefox55: affected → fixed
You need to log in before you can comment on or make changes to this bug.