1371267 - Facebook's volume bar glitches when hovering over the volume button

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

[Affected versions]:
Firefox 55.0a1 (Build Id:20170607030206)

[Unaffected versions]:
Firefox 54.0 (Build Id:20170605134926)
Firefox 53.0.3 (Build Id:20170518000419)
Firefox 52.2.0esr (Build Id:20170607123825)

[Affected platforms]:
 Mac OS X 10.12.1
 Ubuntu 16.04  64bit.
 Windows 10 64 bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Access the https://www.facebook.com/ webpage.
3. Log In.
4. Go to any video.
5. Mute the video.
6. Hover over the volume button.

[Expected result]:
No UI issues are encountered.

[Actual result]:
A glitch can be observed on the volume bar.

[Regression range]:
This seems to be a regression:
Last good revision: baf05f61bc14fdf45511bc1165ce76daa08c5c0f
First bad revision: cf4e37d17683e0cbe134debc1d3685fb3f84e3d1

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=baf05f61bc14fdf45511bc1165ce76daa08c5c0f&tochange=cf4e37d17683e0cbe134debc1d3685fb3f84e3d1

[Additional notes]:
For further details regarding this issue, access the following link to observe the screen cast: https://drive.google.com/open?id=0B94iuIVMr-TETWY3eXptLUhFRVU

No sure if chosen the correct component, fell free to change it if necessary.

Comment 1

[Lee Salzman [:lsalzman]]

Emil, is it possible for you to use mozregression to limit the regression range down to a specific patch? That would help tracking this down.

Comment 2

[Markus Stange [:mstange]]

The most likely candidate in that regression range is bug 1205475.

Comment 3

[Astley Chen (inactive)]

(In reply to Markus Stange [:mstange] from comment #2)
> The most likely candidate in that regression range is bug 1205475.

Yes, I've locally backed out patches in bug 1205475 and the build looks good.

Comment 4

[u459114]

I will handle it.

Comment 5

[u459114]

Attachment: Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

Obvious typo in bug 1205475.

Review commit: https://reviewboard.mozilla.org/r/148798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148798/

Comment 6

[u459114]

Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148798/diff/1-2/

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

https://reviewboard.mozilla.org/r/148798/#review153290

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2574d7124fa
In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child. r=mattwoodrow

Comment 9

[Astley Chen (inactive)]

[Tracking Requested - why for this release]: As FF55 migrated to beta now, we need to uplift the patch to beta when the fix is verified in nightly56.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c2574d7124fa

Comment 11

[Julien Cristau [:jcristau]]

tracking as new regression in 55

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 13

[u459114]

Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1205475
[User impact if declined]: Facebook's volume bar glitches when hovering over the volume button
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]: NA
[Is the change risky?]: no
[Why is the change risky/not risky?]: small patch
[String changes made/needed]:N/A

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8877402 [details]
Bug 1371267 - In nsIFrame::BuildDisplayListForChild, we should get effect-set from the child.

fix a regression in beta55.

No automated test and no manual verification doesn't sound too great though...

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d8707908aa0

Comment 16

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 56.0.2 (BuildId:20171024165158) and Firefox 55.0.3 (BuildId:20170824053622) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.