Closed Bug 1371271 Opened 7 years ago Closed 7 years ago

Early return in WebRenderDisplayItemLayer can result in inconsistent state in display list builder

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1372603

People

(Reporter: kats, Unassigned)

References

Details

(Whiteboard: [gfx-noted]) 

A rebase error between bug 1337761 and bug 1355012 led to the code in WebRenderDisplayItemLayer potentially leaving an unpopped clip in the display list builder because of an early return. See [1]. I'm not sure what conditions this is exercised in but it seems bad.

[1] http://searchfox.org/mozilla-central/rev/1a054419976437d0778a2b89be1b00207a744e94/gfx/layers/wr/WebRenderDisplayItemLayer.cpp#67,86,93
This is fixed in cset 7ece58ca5ca3 (part 3 of bug 1372603) by the removal of the PushClip/PopClip.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.