Toggling full-screen on Photon menu does not cause the Hamburger Menu to disappear on Windows operating systems

VERIFIED FIXED in Firefox 56

Status

()

P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Grover-QA, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 56
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Steps to Reproduce:
1. Set browser.photon.structure.enabled to true
2. Restart browser
3. Navigate to photon hamburger menu
4. Toggle full-screen using the photon menu

Expected Result:
The hamburger menu disappears.

Actual Result:
The hamburger menu stays once full-screen is toggled.

This is only reproducible on Windows operating systems. Not reproducible on Mac or Linux
Flags: qe-verify+
QA Contact: gwimberly
Whiteboard: [photon-structure] [triage]
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
(Assignee)

Updated

a year ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8877561 [details]
Bug 1371311 - make full screen button hide the panel when clicked,

https://reviewboard.mozilla.org/r/149042/#review153890

::: browser/components/customizableui/content/panelUI.inc.xul:578
(Diff revision 1)
> +                         closemenu="none"
>                           tooltip="dynamic-shortcut-tooltip"/>
>            <toolbarbutton id="appMenu-zoomEnlarge-button"
>                           class="subviewbutton subviewbutton-iconic"
>                           command="cmd_fullZoomEnlarge"
> +                         closemenu="none"

Oooh! My bad! Thanks for the fix!
Attachment #8877561 - Flags: review?(mdeboer) → review+

Comment 3

a year ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5fe503c737b6
make full screen button hide the panel when clicked, r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/5fe503c737b6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 5

a year ago
I have reproduced this Bug with Nightly 55.0a1 (2017-06-08) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170616030207
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]
(Reporter)

Comment 6

a year ago
Verified on Windows, Ubuntu, and Mac.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
(Reporter)

Updated

a year ago
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.