1371311 - Toggling full-screen on Photon menu does not cause the Hamburger Menu to disappear on Windows operating systems

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[u554753]

Steps to Reproduce:
1. Set browser.photon.structure.enabled to true
2. Restart browser
3. Navigate to photon hamburger menu
4. Toggle full-screen using the photon menu

Expected Result:
The hamburger menu disappears.

Actual Result:
The hamburger menu stays once full-screen is toggled.

This is only reproducible on Windows operating systems. Not reproducible on Mac or Linux

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1371311 - make full screen button hide the panel when clicked,

Review commit: https://reviewboard.mozilla.org/r/149042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149042/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8877561 [details]
Bug 1371311 - make full screen button hide the panel when clicked,

https://reviewboard.mozilla.org/r/149042/#review153890

::: browser/components/customizableui/content/panelUI.inc.xul:578
(Diff revision 1)
> +                         closemenu="none"
>                           tooltip="dynamic-shortcut-tooltip"/>
>            <toolbarbutton id="appMenu-zoomEnlarge-button"
>                           class="subviewbutton subviewbutton-iconic"
>                           command="cmd_fullZoomEnlarge"
> +                         closemenu="none"

Oooh! My bad! Thanks for the fix!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fe503c737b6
make full screen button hide the panel when clicked, r=mikedeboer

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5fe503c737b6

Comment 5

[Saddam Hossain]

I have reproduced this Bug with Nightly 55.0a1 (2017-06-08) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170616030207
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]

Comment 6

[u554753]

Verified on Windows, Ubuntu, and Mac.