Closed Bug 1371346 Opened 3 years ago Closed 2 years ago
Remove Presentation API system add-on
browser/base/content/test/performance/browser_startup.js indicates that the following scripts are loaded before opening the first window: chrome://presentation/content/PresentationDevicePrompt.jsm
Mike, I see you reviewed this file when it was added. Do you know if this is dead code at this point? It's only built-in if not 'RELEASE_OR_BETA': https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/browser/extensions/moz.build#21
Good question. Hey overholt, is the Presentation API still something we plan on working on in the nearer term? Or can we remove this code for now?
Flags: needinfo?(mconley) → needinfo?(overholt)
No plans in the near term AFAIK.
Okay, thanks! Let's get this out of the tree for now. We can revive the dead code should we decide to pursue the API in the future.
Summary: presentation add-on shouldn't load anything before opening and painting the first browser window → Remove Presentation API system add-on
Whiteboard: [fxperf] → [fxperf:p2]
Comment on attachment 8967785 [details] [diff] [review] 1371346.patch Review of attachment 8967785 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Can you confirm that the tests that are under dom/presentation/tests still pass / don't rely on this stuff?
Attachment #8967785 - Flags: review?(mconley) → review+
Can someone push to try for me?
Sure thing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c7c71d8418312f1d1831829cdbb90da2a845422
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/6046b79949c4 Remove unused/dead Presentation API code. r=mconley
Try looks good, but my patch only stopped including the presentation directory and didn't actually remove it. However, there's really no difference from the tests point of view, I think. I think we're good to land this. Pushed to inbound as: https://hg.mozilla.org/integration/mozilla-inbound/rev/6046b79949c44c5cec26a22490bd695d4cdc7dcb
Backed right out again. Apparently there's some locale stuff that we're missing that didn't burn try, amazingly. https://hg.mozilla.org/integration/mozilla-inbound/rev/c80bf1d63a2a
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f9075c7e8d0f Remove unused/dead Presentation API code. r=mconley
Assignee: nobody → ludovic
You need to log in before you can comment on or make changes to this bug.