Closed
Bug 1371346
Opened 7 years ago
Closed 6 years ago
Remove Presentation API system add-on
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: Usul)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxperf:p2])
Attachments
(1 file)
18.27 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
browser/base/content/test/performance/browser_startup.js indicates that the following scripts are loaded before opening the first window: chrome://presentation/content/PresentationDevicePrompt.jsm
Updated•6 years ago
|
Whiteboard: [fxperf]
Updated•6 years ago
|
Priority: -- → P3
Comment 1•6 years ago
|
||
Mike, I see you reviewed this file when it was added. Do you know if this is dead code at this point? It's only built-in if not 'RELEASE_OR_BETA': https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/browser/extensions/moz.build#21
Flags: needinfo?(mconley)
Comment 2•6 years ago
|
||
Good question. Hey overholt, is the Presentation API still something we plan on working on in the nearer term? Or can we remove this code for now?
Flags: needinfo?(mconley) → needinfo?(overholt)
Comment 4•6 years ago
|
||
Okay, thanks! Let's get this out of the tree for now. We can revive the dead code should we decide to pursue the API in the future.
Summary: presentation add-on shouldn't load anything before opening and painting the first browser window → Remove Presentation API system add-on
Whiteboard: [fxperf] → [fxperf:p2]
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8967785 -
Flags: review?(mconley)
Comment 6•6 years ago
|
||
Comment on attachment 8967785 [details] [diff] [review] 1371346.patch Review of attachment 8967785 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Can you confirm that the tests that are under dom/presentation/tests still pass / don't rely on this stuff?
Attachment #8967785 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 7•6 years ago
|
||
Can someone push to try for me?
Comment 8•6 years ago
|
||
Sure thing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c7c71d8418312f1d1831829cdbb90da2a845422
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6046b79949c4 Remove unused/dead Presentation API code. r=mconley
Comment 10•6 years ago
|
||
Try looks good, but my patch only stopped including the presentation directory and didn't actually remove it. However, there's really no difference from the tests point of view, I think. I think we're good to land this. Pushed to inbound as: https://hg.mozilla.org/integration/mozilla-inbound/rev/6046b79949c44c5cec26a22490bd695d4cdc7dcb
Comment 11•6 years ago
|
||
Backed right out again. Apparently there's some locale stuff that we're missing that didn't burn try, amazingly. https://hg.mozilla.org/integration/mozilla-inbound/rev/c80bf1d63a2a
Comment 12•6 years ago
|
||
https://searchfox.org/mozilla-central/rev/bd326a2a6b729dc62a5aee57354a97ceac4d1dc0/browser/locales/Makefile.in#79-81,101-103 needs to be removed too.
Comment 13•6 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f9075c7e8d0f Remove unused/dead Presentation API code. r=mconley
Updated•6 years ago
|
Assignee: nobody → ludovic
Flags: needinfo?(mconley)
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f9075c7e8d0f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•