Closed
Bug 1371406
Opened 8 years ago
Closed 8 years ago
Update builders to rust 1.18.0
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
Update official builds to use rust 1.18.0. This should wait for Firefox 56.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → giles
|
||
Comment 2•8 years ago
|
||
Thank you for waiting until Firefox 56.
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.
https://reviewboard.mozilla.org/r/147266/#review152986
Is there any reason not to update MODERN_RUST_VERSION to 1.18.0 as well now that all the builders are 1.18.0? If not, please update it as part of this patch.
Attachment #8875866 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.
https://reviewboard.mozilla.org/r/147266/#review152986
Thanks. MODERN_RUST_VERSION was updated last week in bug 1371366.
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05dca51f91e6
Update builders to rust 1.18.0. r=mshal
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 8•8 years ago
|
||
Ralph, can you confirm that this means that all builds from automation will use Rust 1.18? That version introduced field re-ordering optimizations that should significantly improve CSS parsing performance and memory usage (see bug 1375336).
Flags: needinfo?(giles)
|
|
Assignee | |
Comment 9•8 years ago
|
||
That's correct. Official Firefox Nightly builds are built with 1.18.
Flags: needinfo?(giles)
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•