Closed Bug 1371406 Opened 3 years ago Closed 3 years ago

Update builders to rust 1.18.0

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Update official builds to use rust 1.18.0. This should wait for Firefox 56.
Assignee: nobody → giles
Thank you for waiting until Firefox 56.
Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.

https://reviewboard.mozilla.org/r/147266/#review152986

Is there any reason not to update MODERN_RUST_VERSION to 1.18.0 as well now that all the builders are 1.18.0? If not, please update it as part of this patch.
Attachment #8875866 - Flags: review?(mshal) → review+
Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.

https://reviewboard.mozilla.org/r/147266/#review152986

Thanks. MODERN_RUST_VERSION was updated last week in bug 1371366.
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05dca51f91e6
Update builders to rust 1.18.0. r=mshal
https://hg.mozilla.org/mozilla-central/rev/05dca51f91e6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Ralph, can you confirm that this means that all builds from automation will use Rust 1.18? That version introduced field re-ordering optimizations that should significantly improve CSS parsing performance and memory usage (see bug 1375336).
Flags: needinfo?(giles)
That's correct. Official Firefox Nightly builds are built with 1.18.
Flags: needinfo?(giles)
Blocks: 1382743
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.