1371406 - Update builders to rust 1.18.0

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Update official builds to use rust 1.18.0. This should wait for Firefox 56.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1371406 - Update builders to rust 1.18.0.

New stable release.

Slightly faster build times, finer-grained 'pub' and better
struct packing.

Review commit: https://reviewboard.mozilla.org/r/147266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147266/

Comment 2

[Gregory Szorc [:gps]]

Thank you for waiting until Firefox 56.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147266/diff/1-2/

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.

https://reviewboard.mozilla.org/r/147266/#review152986

Is there any reason not to update MODERN_RUST_VERSION to 1.18.0 as well now that all the builders are 1.18.0? If not, please update it as part of this patch.

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8875866 [details]
Bug 1371406 - Update builders to rust 1.18.0.

https://reviewboard.mozilla.org/r/147266/#review152986

Thanks. MODERN_RUST_VERSION was updated last week in bug 1371366.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05dca51f91e6
Update builders to rust 1.18.0. r=mshal

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05dca51f91e6

Comment 8

[Bobby Holley (:bholley)]

Ralph, can you confirm that this means that all builds from automation will use Rust 1.18? That version introduced field re-ordering optimizations that should significantly improve CSS parsing performance and memory usage (see bug 1375336).

Comment 9

[Ralph Giles (:rillian)]

That's correct. Official Firefox Nightly builds are built with 1.18.