Use AutoTArray to save current listener in NotifySelectionListeners

RESOLVED FIXED in Firefox 55

Status

()

Core
Selection
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

55 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Actually, we use nsCOMArray for mSelectionListeners.  NotifySelectionListeners saves current listeners to another nsCOMArray then use it for observing.

When I debug it, array length is mostly ~5, and nsCOMArray uses malloc according to profiler.  So since array length is small, we should use AutoTArray instead.
(Assignee)

Updated

11 months ago
Blocks: 1346723
Comment hidden (mozreview-request)

Comment 2

11 months ago
Comment on attachment 8876008 [details]
Bug 1371492 - Use AutoTArray to save current listener in NotifySelectionListeners.

I'll defer to smaug on this one.
Attachment #8876008 - Flags: review?(mats) → review?(bugs)

Comment 3

11 months ago
mozreview-review
Comment on attachment 8876008 [details]
Bug 1371492 - Use AutoTArray to save current listener in NotifySelectionListeners.

https://reviewboard.mozilla.org/r/147450/#review151862
Attachment #8876008 - Flags: review?(bugs) → review+

Comment 4

11 months ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/11e9775fd375
Use AutoTArray to save current listener in NotifySelectionListeners. r=smaug

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11e9775fd375
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.