1371626 - dom/plugins/test/testplugin/nptest.cpp:459:13: error: '%x' directive writing between 1 and 8 bytes into a region of size 7 [-Werror=format-overflow=]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Fails the build with --enable-warnings-as-errors

In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dom/plugins/test/testplugin/javaplugin/Unified_cpp_javaplugin0.cpp:11:0:
/root/firefox-gcc-last/dom/plugins/test/testplugin/nptest.cpp: In function 'void sendBufferToFrame(NPP)':
/root/firefox-gcc-last/dom/plugins/test/testplugin/nptest.cpp:459:13: error: '%x' directive writing between 1 and 8 bytes into a region of size 7 [-Werror=format-overflow=]
 static void sendBufferToFrame(NPP instance)
             ^~~~~~~~~~~~~~~~~
/root/firefox-gcc-last/dom/plugins/test/testplugin/nptest.cpp:459:13: note: using the range [0, 4294967295] for directive argument
/root/firefox-gcc-last/dom/plugins/test/testplugin/nptest.cpp:531:18: note: 'sprintf' output between 3 and 10 bytes into a destination of size 8
           sprintf(hex, "%%%x", ascii);
           ~~~~~~~^~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1371626 - Fix a format-overflow issue with gcc 7.1

Review commit: https://reviewboard.mozilla.org/r/147524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147524/

Comment 2

[Benjamin Smedberg]

Comment on attachment 8876098 [details]
Bug 1371626 - Fix a format-overflow issue with gcc 7.1

https://reviewboard.mozilla.org/r/147524/#review151998

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e925cbe7976
Fix a format-overflow issue with gcc 7.1 r=bsmedberg

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7e925cbe7976