Don't create an MSG if it's not going to be used immediately

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: MediaStreamGraph
P2
normal
Rank:
21
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
When separating the MSGs per docgroup or document, `test_eme_stream_capture_blocked_case3.html` calls `MediaStreamGraph::GetInstance`, and then fails to create a stream because it's not allowed (because of, here, EME), and the MSG sits there doing nothing until the end of the process, and can't shut down because it's not progressed in its life cycle state machine.

This is a footgun, and we should try to make it impossible to create an MSG without a stream, but in the meantime, this does the trick.
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Blocks: 1330360

Comment 2

6 months ago
mozreview-review
Comment on attachment 8876192 [details]
Bug 1371719 - Don't create a MediaStreamGraph without doing anything with it.

https://reviewboard.mozilla.org/r/147634/#review152034
Attachment #8876192 - Flags: review?(rjesup) → review+
(Assignee)

Updated

6 months ago
Assignee: nobody → padenot

Updated

6 months ago
Rank: 21
Priority: -- → P2

Comment 3

5 months ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4d113ff7fb
Don't create a MediaStreamGraph without doing anything with it.  r=jesup

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c4d113ff7fb
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

5 months ago
Blocks: 1384247
No longer blocks: 1384247
Depends on: 1384247
You need to log in before you can comment on or make changes to this bug.