Closed Bug 1371759 Opened 4 years ago Closed 4 years ago

Port bug 1323188 to C-C [Don't use restricting SIDs in the sandbox access tokens when running from a network drive]

Categories

(MailNews Core :: Security, enhancement)

Product:
MailNews Core
Component:
Security
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 55.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

sandbox.patch
2.53 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
Simply port it.
Attached patch sandbox.patch (obsolete) — — Splinter Review 
Port it.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8876232 - Flags: review?(jorgk)
Comment on attachment 8876232 [details] [diff] [review]
sandbox.patch

What about the other stuff that M-C has and we don't?

+  sandboxing::NetworkDriveCheck();
   sandboxing::PermissionsService* permissionsService =
     sandboxing::GetPermissionsService();
 #if defined(MOZ_CONTENT_SANDBOX)
   if (!brokerServices) {
     Output("Couldn't initialize the broker services.\n");
     return 255;
   }
 #endif

When was that landed? Should we port this as well?
Attached patch sandbox.patch — — Splinter Review 
Uhh, my bad. I inserted it after the wrong line.
Attachment #8876232 - Attachment is obsolete: true
Attachment #8876232 - Flags: review?(jorgk)
Attachment #8876238 - Flags: review?(jorgk)
Comment on attachment 8876238 [details] [diff] [review]
sandbox.patch

That looks more like it ;-)
Attachment #8876238 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3e3745b52dc53eb74efd73d3107a81e2e13f94be
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.