1371871 - Misc fixes for an artifact build from the Tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

A few fixes on top of bug 1371817 and bug 1319222 can get us a working artifact build based on Tup

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1371871 - Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend.

Review commit: https://reviewboard.mozilla.org/r/148724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148724/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1371871 - Do not process XPIDL in the tup backend during an artifact build.

Review commit: https://reviewboard.mozilla.org/r/148726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148726/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1371871 - Do not install unnecessary files in an artifact build.

This prevents us from redundantly installing httpd.js and httpd.manifest
from the test package during an artifact build, which interferes with
the Tup backend's handling of these files as symlinks.

Review commit: https://reviewboard.mozilla.org/r/148728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148728/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1371871 - Run the artifact tier during a tup artifact build.

Review commit: https://reviewboard.mozilla.org/r/148730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148730/

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8877358 [details]
Bug 1371871 - Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend.

https://reviewboard.mozilla.org/r/148724/#review154178

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8877359 [details]
Bug 1371871 - Do not process XPIDL in the tup backend during an artifact build.

https://reviewboard.mozilla.org/r/148726/#review154182

Seems reasonable. Is there any benefit to making this common to all backends? I guess the make backend just does this in the Makefile.in, so maybe not.

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 8877360 [details]
Bug 1371871 - Do not install unnecessary files in an artifact build.

https://reviewboard.mozilla.org/r/148728/#review154184

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8877361 [details]
Bug 1371871 - Run the artifact tier during a tup artifact build.

https://reviewboard.mozilla.org/r/148730/#review154186

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8877358 [details]
Bug 1371871 - Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148724/diff/1-2/

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8877359 [details]
Bug 1371871 - Do not process XPIDL in the tup backend during an artifact build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148726/diff/1-2/

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8877360 [details]
Bug 1371871 - Do not install unnecessary files in an artifact build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148728/diff/1-2/

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8877361 [details]
Bug 1371871 - Run the artifact tier during a tup artifact build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148730/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da33901ca34a
Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend. r=mshal
https://hg.mozilla.org/integration/autoland/rev/13e4d84bb4e9
Do not process XPIDL in the tup backend during an artifact build. r=mshal
https://hg.mozilla.org/integration/autoland/rev/4807dbbaccc3
Do not install unnecessary files in an artifact build. r=mshal
https://hg.mozilla.org/integration/autoland/rev/0d28abfd6ad4
Run the artifact tier during a tup artifact build. r=mshal

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da33901ca34a
https://hg.mozilla.org/mozilla-central/rev/13e4d84bb4e9
https://hg.mozilla.org/mozilla-central/rev/4807dbbaccc3
https://hg.mozilla.org/mozilla-central/rev/0d28abfd6ad4