Closed Bug 1371871 Opened 3 years ago Closed 3 years ago

Misc fixes for an artifact build from the Tup backend

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(4 files)

A few fixes on top of bug 1371817 and bug 1319222 can get us a working artifact build based on Tup
Comment on attachment 8877358 [details]
Bug 1371871 - Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend.

https://reviewboard.mozilla.org/r/148724/#review154178
Attachment #8877358 - Flags: review?(mshal) → review+
Comment on attachment 8877359 [details]
Bug 1371871 - Do not process XPIDL in the tup backend during an artifact build.

https://reviewboard.mozilla.org/r/148726/#review154182

Seems reasonable. Is there any benefit to making this common to all backends? I guess the make backend just does this in the Makefile.in, so maybe not.
Attachment #8877359 - Flags: review?(mshal) → review+
Comment on attachment 8877360 [details]
Bug 1371871 - Do not install unnecessary files in an artifact build.

https://reviewboard.mozilla.org/r/148728/#review154184
Attachment #8877360 - Flags: review?(mshal) → review+
Comment on attachment 8877361 [details]
Bug 1371871 - Run the artifact tier during a tup artifact build.

https://reviewboard.mozilla.org/r/148730/#review154186
Attachment #8877361 - Flags: review?(mshal) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da33901ca34a
Do not generate or attempt to install unnecessary files in artifact builds in the Tup backend. r=mshal
https://hg.mozilla.org/integration/autoland/rev/13e4d84bb4e9
Do not process XPIDL in the tup backend during an artifact build. r=mshal
https://hg.mozilla.org/integration/autoland/rev/4807dbbaccc3
Do not install unnecessary files in an artifact build. r=mshal
https://hg.mozilla.org/integration/autoland/rev/0d28abfd6ad4
Run the artifact tier during a tup artifact build. r=mshal
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.