1371900 - Move implementation of ProcessedStack out of Telemetry.cpp

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Iaroslav Sheptykin]

Definition of the ProcessedStack lives in [.h](https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/ProcessedStack.h) file but the [implementation](https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Telemetry.cpp#2459-2590) is still in the Telemetry.cpp file. Let factor the implementation out in order to decrease the size of Telemetry.cpp

Comment 1

[Iaroslav Sheptykin]

Attachment: Bug 1371900: Factored ProcessedStack out of Telemetry.cpp.

Review commit: https://reviewboard.mozilla.org/r/147776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147776/

Comment 2

[Iaroslav Sheptykin]

Not sure if you get notified about review requests, so adding a needinfo here. I submitted a first draft for factoring ProcessedStack out. The work was very straightforward. Do you need line-wise diffs for this patch?

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8876419 [details]
Bug 1371900: Factored ProcessedStack out of Telemetry.cpp.

https://reviewboard.mozilla.org/r/147776/#review153388

Thanks, this looks good.

Only one small indentation fix is needed, then we can land this.
You don't need to re-request review after that fix.

::: toolkit/components/telemetry/ProcessedStack.cpp:14
(Diff revision 1)
> +#include "shared-libraries.h"
> +#endif // MOZ_GECKO_PROFILER
> +
> +namespace {
> +
> +  struct StackFrame

We don't use extra indentation inside namespaces.

Comment 4

[Iaroslav Sheptykin]

Comment on attachment 8876419 [details]
Bug 1371900: Factored ProcessedStack out of Telemetry.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147776/diff/1-2/

Comment 5

[Iaroslav Sheptykin]

:gfritzsche, I addressed the feedback for the last patch re-based it onto the latest central and tried building without profiler. Everything looks ok. I scheduled a trybuild with tests. If that goes well we can try landing this patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8280a4445c3
Factored ProcessedStack out of Telemetry.cpp. r=gfritzsche

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8280a4445c3