1371908 - GlobalHelperThreadState::mergeParseTaskCompartment finishes GC at random times

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

If we want to avoid running GC at possibly bad times, this kind of explicit GC calls should be removed if possible.

http://searchfox.org/mozilla-central/rev/12afa8cc9cea4a141494f767541b411845eef7a0/js/src/vm/HelperThreads.cpp#1554

Comment 1

[Jan de Mooij [:jandem]]

As a first step we could easily check if the incremental GC affects the current Zone right? That way a parse task in Zone A is not going to affect an incremental GC of Zone B...

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Jan de Mooij [:jandem] from comment #1)
Yes, good idea.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1371908-dont-finsish-gc-on-merge

Patch to only finish an incremental GC if the destination zone is being collected when merging compartments (the source zone should never be being collected at this point).

I also included the test code for bug 1146213 which I forgot to land after the fact, which also tests this area.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8876725 [details] [diff] [review]
bug1371908-dont-finsish-gc-on-merge

Review of attachment 8876725 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a17ea8524638
When merging compartments only finish an ongoing GC if it affects the destination compartment r=sfink

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a17ea8524638