Closed Bug 1371956 Opened 8 years ago Closed 8 years ago

EnsureFrameInApproximatelyVisibleList does an unnecessary hashtable lookup

Categories

(Core :: Layout, enhancement, P2)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: perf)

Attachments

(1 file)

Use mApproximatelyVisibleFrames.EnsureInserted/EnsureRemoved to avoid doing unnecessary hashtable lookups
3.60 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
No description provided.
Converting some handrolled "compare Count() before/after" checks to use EnsureInserted/EnsureRemoved instead. However, there was one place still using Contains+PutEntry.
Attachment #8876439 - Flags: review?(nfroyd)
Attachment #8876439 - Flags: review?(nfroyd) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2c36d660c2 Use mApproximatelyVisibleFrames.EnsureInserted/EnsureRemoved to avoid doing unnecessary hashtable lookups. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/8b2c36d660c2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: