1371991 - Do not link against libcrmf

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[userwithuid]

libcrmf from nss seems to be unused since bug 1030963 removed the crypto api stuff that used it. Can -lcrmf be removed from the build system?



Code:

For sys-nss, old-configure.in currently has

if test -n "$MOZ_SYSTEM_NSS"; then
   NSS_LIBS="$NSS_LIBS -lcrmf"

and for in-tree-nss, security/manager/ssl/moz.build has

if not CONFIG['MOZ_SYSTEM_NSS']:
    USE_LIBS += [
        'crmf',

relating to this (at first glance).



Downstream:

Arch: https://bugs.archlinux.org/task/5439
Also, looks like OpenEmbedded discovered this a couple of months ago as well: https://github.com/OSSystems/meta-browser/blob/249f674dcc62b70e570cec581ae9e0b2a4319c7d/recipes-mozilla/firefox/firefox/0003-do-not-link-against-crmf-library-it-is-not-there.patch

Comment 1

[userwithuid]

The arch bug link should be: https://bugs.archlinux.org/task/54395

Comment 2

[(not currently active) Ted Mielczarek]

CCing some NSS folks. If we do remove this dependency we could also fix the nss.gyp file to not build libcrmf for the Mozilla build:
https://hg.mozilla.org/projects/nss/file/1bca0a132021/nss.gyp#l49

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

SGTM. Either we use -Dmozilla_client=1 or we introduce something new like -Ddisable_crmf.

Comment 4

[robsmith11]

This is still broken when building with system nss in 59b4.

Comment 5

[tt_1]

Could it be that crmf was reintroduced in latest nss? I think that Arch linux stopped backing it out, if I understand their build script of firefox correctly. In this case, the bug here might be obsolete?

Comment 6

[Jan Alexander Steffens [:heftig]]

No, the -lcrmf argument is still being removed.

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/firefox#n49

Comment 7

[Phabricator Automation]

Attachment: Bug 1371991 - don't link against crmf when building with --with-system-nss, r=ted

Comment 8

[Phabricator Automation]

Comment on attachment 8964493 [details]
Bug 1371991 - don't link against crmf when building with --with-system-nss, r=ted

Ted Mielczarek [:ted.mielczarek] has approved the revision.

https://phabricator.services.mozilla.com/D836

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f242fa9cd57f
don't link against crmf when building with --with-system-nss, r=ted

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f242fa9cd57f

Comment 11

[tt_1]

Can you please give this a push to the 60.0 branch as well?

Comment 12

[Franziskus Kiefer [:franziskus]]

I don't think this is something we want to uplift to beta. But marking it for the release drivers so they can decide.

Comment 13

[Julien Cristau [:jcristau]]

What's the benefit of this change?  Pretend I don't know what libcrmf is.

Comment 14

[Jan Alexander Steffens [:heftig]]

Building NSS as a system library (using gyp) does not include libcrmf, so a Firefox build with --with-system-nss will fail. Since libcrmf is (no longer) used by Firefox, the link argument can be removed to fix the build without impacting Firefox's functionality.

Comment 15

[Julien Cristau [:jcristau]]

ok, sounds like this wouldn't hurt, if someone wants to request uplift.

Comment 16

[tt_1]

So, can we get an uplift to the new esr branch? This is kind of painfull for distros, because they have to "backport" the patch every time the nss deps in the script gets raised.

Comment 17

[Julien Cristau [:jcristau]]

Franziskus, mind requesting uplift to esr60?

Comment 18

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8964493 [details]
Bug 1371991 - don't link against crmf when building with --with-system-nss, r=ted

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Patching Firefox with system NSS is a hassle for maintainers. This minimal patch can make their life easier.
User impact if declined: Probably none, but Linux distributions might not take Firefox release or publish them with delay.
Fix Landed on Version: 61
Risk to taking this patch (and alternatives if risky): Not risky. The linked library is not used by Firefox.
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 19

[Julien Cristau [:jcristau]]

Comment on attachment 8964493 [details]
Bug 1371991 - don't link against crmf when building with --with-system-nss, r=ted

approved for 60.1esr

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/3ac8f220f7e6